diff options
| author | Joel Challis <git@zvecr.com> | 2020-01-30 23:44:40 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-01-31 10:44:40 +1100 |
| commit | 4139de3cc9c56a157d78e1e418893d08e3f23bde (patch) | |
| tree | c1822b9710b9bfeef43c10fc4a49d24050744558 /keyboards/amj96 | |
| parent | 7514f5124ac81ce1db51eb07a287f82d6a9bf10c (diff) | |
| download | firmware-4139de3cc9c56a157d78e1e418893d08e3f23bde.tar.gz firmware-4139de3cc9c56a157d78e1e418893d08e3f23bde.tar.bz2 firmware-4139de3cc9c56a157d78e1e418893d08e3f23bde.zip | |
Fix AVR boards which were overriding backlight without setting… (#8044)
* Add backlight custom driver to all boards not declaring it but overriding backlight
* Apply suggestions from code review
Co-Authored-By: fauxpark <fauxpark@gmail.com>
* Apply suggestions from code review
Co-Authored-By: fauxpark <fauxpark@gmail.com>
* Remove old tmk references from show_options.mk
Co-authored-by: fauxpark <fauxpark@gmail.com>
Diffstat (limited to 'keyboards/amj96')
| -rw-r--r-- | keyboards/amj96/config.h | 16 | ||||
| -rw-r--r-- | keyboards/amj96/rules.mk | 6 |
2 files changed, 3 insertions, 19 deletions
diff --git a/keyboards/amj96/config.h b/keyboards/amj96/config.h index 1f1be03ce..8b56aaf7f 100644 --- a/keyboards/amj96/config.h +++ b/keyboards/amj96/config.h @@ -47,22 +47,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. /* COL2ROW, ROW2COL*/ #define DIODE_DIRECTION COL2ROW -// #define BACKLIGHT_PIN D4 -// #define BACKLIGHT_BREATHING -// #define BACKLIGHT_LEVELS 3 - -/* number of backlight levels */ -#ifdef BREATHING_LED_ENABLE -#ifdef FADING_LED_ENABLE -#define BACKLIGHT_LEVELS 8 -#else -#define BACKLIGHT_LEVELS 6 -#endif -#else -#define BACKLIGHT_LEVELS 3 -#endif -#define BACKLIGHT_CUSTOM - /* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */ #define DEBOUNCE 5 diff --git a/keyboards/amj96/rules.mk b/keyboards/amj96/rules.mk index e6838d719..4fd858509 100644 --- a/keyboards/amj96/rules.mk +++ b/keyboards/amj96/rules.mk @@ -14,7 +14,7 @@ BOOTLOADER = atmel-dfu # Build Options # change yes to no to disable # -BOOTMAGIC_ENABLE = no # Virtual DIP switch configuration +BOOTMAGIC_ENABLE = no # Virtual DIP switch configuration MOUSEKEY_ENABLE = yes # Mouse keys EXTRAKEY_ENABLE = yes # Audio control and System control CONSOLE_ENABLE = yes # Console for debug @@ -22,8 +22,8 @@ COMMAND_ENABLE = no # Commands for debug and configuration # Do not enable SLEEP_LED_ENABLE. it uses the same timer as BACKLIGHT_ENABLE SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend # if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work -NKRO_ENABLE ?= yes # USB Nkey Rollover -BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality on B7 by default +NKRO_ENABLE = yes # USB Nkey Rollover +BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality RGBLIGHT_ENABLE = yes MIDI_ENABLE = no # MIDI support UNICODE_ENABLE = no # Unicode |