Content-Security-Policy: default-src 'none'
Content-Type: text/plain; charset=UTF-8
Content-Length: 685
Content-Disposition: inline; filename="308-ath9k-clear-potentially-stale-EOSP-status-bit-in-int.patch"
Last-Modified: Wed, 13 Nov 2024 06:46:56 GMT
Expires: Sat, 11 Nov 2034 06:46:56 GMT
ETag: "929da25d75d37259b93258d9fffbba252b3c41b6"

From: Felix Fietkau <nbd@nbd.name>
Date: Sun, 28 Aug 2016 13:13:42 +0200
Subject: [PATCH] ath9k: clear potentially stale EOSP status bit in
 intermediate queues

Prevents spurious ieee80211_sta_eosp calls.

Signed-off-by: Felix Fietkau <nbd@nbd.name>
---

--- a/drivers/net/wireless/ath/ath9k/xmit.c
+++ b/drivers/net/wireless/ath/ath9k/xmit.c
@@ -945,7 +945,8 @@ ath_tx_get_tid_subframe(struct ath_softc
 		bf->bf_lastbf = bf;
 
 		tx_info = IEEE80211_SKB_CB(skb);
-		tx_info->flags &= ~IEEE80211_TX_CTL_CLEAR_PS_FILT;
+		tx_info->flags &= ~(IEEE80211_TX_CTL_CLEAR_PS_FILT |
+				    IEEE80211_TX_STATUS_EOSP);
 
 		/*
 		 * No aggregation session is running, but there may be frames
wspan='2'><a href='/cgit/'><img src='/cgit.png' alt='cgit logo'/></a></td>
<td class='main'><a href='/cgit/'>index</a> : <a title='openwrt/upstream' href='/cgit/openwrt/upstream/'>openwrt/upstream</a></td><td class='form'><form method='get'>
<input type='hidden' name='id' value='07df80a1a61504e2b79cfee5e138f1d38db8ea66'/><select name='h' onchange='this.form.submit();'>
<option value='attitude_adjustment'>attitude_adjustment</option>
<option value='barrier_breaker'>barrier_breaker</option>
<option value='chaos_calmer'>chaos_calmer</option>
<option value='lede-17.01'>lede-17.01</option>
<option value='less-old-master'>less-old-master</option>
<option value='master'>master</option>
<option value='old-master'>old-master</option>
<option value='openwrt-18.06'>openwrt-18.06</option>
<option value='openwrt-19.07'>openwrt-19.07</option>
<option value='upstream'>upstream</option>
</select> <input type='submit' value='switch'/></form></td></tr>
<tr><td class='sub'>upstream openwrt</td><td class='sub right'>James</td></tr></table>
<table class='tabs'><tr><td>
<a href='/cgit/openwrt/upstream/about/?h=v22.03.1'>about</a><a href='/cgit/openwrt/upstream/?h=v22.03.1'>summary</a><a href='/cgit/openwrt/upstream/refs/?h=v22.03.1&amp;id=07df80a1a61504e2b79cfee5e138f1d38db8ea66'>refs</a><a href='/cgit/openwrt/upstream/log/package/kernel/mac80211/patches/861-brcmfmac-workaround-bug-with-some-inconsistent-BSSes.patch?h=v22.03.1'>log</a><a class='active' href='/cgit/openwrt/upstream/tree/package/kernel/mac80211/patches/861-brcmfmac-workaround-bug-with-some-inconsistent-BSSes.patch?h=v22.03.1&amp;id=07df80a1a61504e2b79cfee5e138f1d38db8ea66'>tree</a><a href='/cgit/openwrt/upstream/commit/package/kernel/mac80211/patches/861-brcmfmac-workaround-bug-with-some-inconsistent-BSSes.patch?h=v22.03.1&amp;id=07df80a1a61504e2b79cfee5e138f1d38db8ea66'>commit</a><a href='/cgit/openwrt/upstream/diff/package/kernel/mac80211/patches/861-brcmfmac-workaround-bug-with-some-inconsistent-BSSes.patch?h=v22.03.1&amp;id=07df80a1a61504e2b79cfee5e138f1d38db8ea66'>diff</a><a href='/cgit/openwrt/upstream/stats/package/kernel/mac80211/patches/861-brcmfmac-workaround-bug-with-some-inconsistent-BSSes.patch?h=v22.03.1'>stats</a></td><td class='form'><form class='right' method='get' action='/cgit/openwrt/upstream/log/package/kernel/mac80211/patches/861-brcmfmac-workaround-bug-with-some-inconsistent-BSSes.patch'>
<input type='hidden' name='h' value='v22.03.1'/><input type='hidden' name='id' value='07df80a1a61504e2b79cfee5e138f1d38db8ea66'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/cgit/openwrt/upstream/tree/?h=v22.03.1&amp;id=07df80a1a61504e2b79cfee5e138f1d38db8ea66'>root</a>/<a href='/cgit/openwrt/upstream/tree/package?h=v22.03.1&amp;id=07df80a1a61504e2b79cfee5e138f1d38db8ea66'>package</a>/<a href='/cgit/openwrt/upstream/tree/package/kernel?h=v22.03.1&amp;id=07df80a1a61504e2b79cfee5e138f1d38db8ea66'>kernel</a>/<a href='/cgit/openwrt/upstream/tree/package/kernel/mac80211?h=v22.03.1&amp;id=07df80a1a61504e2b79cfee5e138f1d38db8ea66'>mac80211</a>/<a href='/cgit/openwrt/upstream/tree/package/kernel/mac80211/patches?h=v22.03.1&amp;id=07df80a1a61504e2b79cfee5e138f1d38db8ea66'>patches</a>/<a href='/cgit/openwrt/upstream/tree/package/kernel/mac80211/patches/861-brcmfmac-workaround-bug-with-some-inconsistent-BSSes.patch?h=v22.03.1&amp;id=07df80a1a61504e2b79cfee5e138f1d38db8ea66'>861-brcmfmac-workaround-bug-with-some-inconsistent-BSSes.patch</a></div><div class='content'>blob: 87211550f77d6e06bef8f7124940ba30ac4222ef (<a href='/cgit/openwrt/upstream/plain/package/kernel/mac80211/patches/861-brcmfmac-workaround-bug-with-some-inconsistent-BSSes.patch?h=v22.03.1&amp;id=07df80a1a61504e2b79cfee5e138f1d38db8ea66'>plain</a>)
<table summary='blob content' class='blob'>
<tr><td class='linenumbers'><pre><a id='n1' href='#n1'>1</a>
<a id='n2' href='#n2'>2</a>
<a id='n3' href='#n3'>3</a>
<a id='n4' href='#n4'>4</a>
<a id='n5' href='#n5'>5</a>
<a id='n6' href='#n6'>6</a>
<a id='n7' href='#n7'>7</a>
<a id='n8' href='#n8'>8</a>
<a id='n9' href='#n9'>9</a>
<a id='n10' href='#n10'>10</a>
<a id='n11' href='#n11'>11</a>
<a id='n12' href='#n12'>12</a>
<a id='n13' href='#n13'>13</a>
<a id='n14' href='#n14'>14</a>
<a id='n15' href='#n15'>15</a>
<a id='n16' href='#n16'>16</a>
<a id='n17' href='#n17'>17</a>
<a id='n18' href='#n18'>18</a>
<a id='n19' href='#n19'>19</a>
<a id='n20' href='#n20'>20</a>
<a id='n21' href='#n21'>21</a>
<a id='n22' href='#n22'>22</a>
<a id='n23' href='#n23'>23</a>
<a id='n24' href='#n24'>24</a>
<a id='n25' href='#n25'>25</a>
<a id='n26' href='#n26'>26</a>
<a id='n27' href='#n27'>27</a>
<a id='n28' href='#n28'>28</a>
<a id='n29' href='#n29'>29</a>
<a id='n30' href='#n30'>30</a>
<a id='n31' href='#n31'>31</a>
<a id='n32' href='#n32'>32</a>
<a id='n33' href='#n33'>33</a>
<a id='n34' href='#n34'>34</a>
<a id='n35' href='#n35'>35</a>
<a id='n36' href='#n36'>36</a>
<a id='n37' href='#n37'>37</a>
<a id='n38' href='#n38'>38</a>
<a id='n39' href='#n39'>39</a>
<a id='n40' href='#n40'>40</a>
<a id='n41' href='#n41'>41</a>
<a id='n42' href='#n42'>42</a>
<a id='n43' href='#n43'>43</a>
<a id='n44' href='#n44'>44</a>
<a id='n45' href='#n45'>45</a>
<a id='n46' href='#n46'>46</a>
<a id='n47' href='#n47'>47</a>
<a id='n48' href='#n48'>48</a>
<a id='n49' href='#n49'>49</a>
<a id='n50' href='#n50'>50</a>
</pre></td>
<td class='lines'><pre><code><style>pre { line-height: 125%; margin: 0; }
td.linenos pre { color: #000000; background-color: #f0f0f0; padding: 0 5px 0 5px; }
span.linenos { color: #000000; background-color: #f0f0f0; padding: 0 5px 0 5px; }
td.linenos pre.special { color: #000000; background-color: #ffffc0; padding: 0 5px 0 5px; }
span.linenos.special { color: #000000; background-color: #ffffc0; padding: 0 5px 0 5px; }
.highlight .hll { background-color: #ffffcc }
.highlight { background: #ffffff; }
.highlight .c { color: #888888 } /* Comment */
.highlight .err { color: #a61717; background-color: #e3d2d2 } /* Error */
.highlight .k { color: #008800; font-weight: bold } /* Keyword */
.highlight .ch { color: #888888 } /* Comment.Hashbang */
.highlight .cm { color: #888888 } /* Comment.Multiline */
.highlight .cp { color: #cc0000; font-weight: bold } /* Comment.Preproc */
.highlight .cpf { color: #888888 } /* Comment.PreprocFile */
.highlight .c1 { color: #888888 } /* Comment.Single */
.highlight .cs { color: #cc0000; font-weight: bold; background-color: #fff0f0 } /* Comment.Special */
.highlight .gd { color: #000000; background-color: #ffdddd } /* Generic.Deleted */
.highlight .ge { font-style: italic } /* Generic.Emph */
.highlight .gr { color: #aa0000 } /* Generic.Error */
.highlight .gh { color: #333333 } /* Generic.Heading */
.highlight .gi { color: #000000; background-color: #ddffdd } /* Generic.Inserted */
.highlight .go { color: #888888 } /* Generic.Output */
.highlight .gp { color: #555555 } /* Generic.Prompt */
.highlight .gs { font-weight: bold } /* Generic.Strong */
.highlight .gu { color: #666666 } /* Generic.Subheading */
.highlight .gt { color: #aa0000 } /* Generic.Traceback */
.highlight .kc { color: #008800; font-weight: bold } /* Keyword.Constant */
.highlight .kd { color: #008800; font-weight: bold } /* Keyword.Declaration */
.highlight .kn { color: #008800; font-weight: bold } /* Keyword.Namespace */
.highlight .kp { color: #008800 } /* Keyword.Pseudo */
.highlight .kr { color: #008800; font-weight: bold } /* Keyword.Reserved */
.highlight .kt { color: #888888; font-weight: bold } /* Keyword.Type */
.highlight .m { color: #0000DD; font-weight: bold } /* Literal.Number */
.highlight .s { color: #dd2200; background-color: #fff0f0 } /* Literal.String */
.highlight .na { color: #336699 } /* Name.Attribute */
.highlight .nb { color: #003388 } /* Name.Builtin */
.highlight .nc { color: #bb0066; font-weight: bold } /* Name.Class */
.highlight .no { color: #003366; font-weight: bold } /* Name.Constant */
.highlight .nd { color: #555555 } /* Name.Decorator */
.highlight .ne { color: #bb0066; font-weight: bold } /* Name.Exception */
.highlight .nf { color: #0066bb; font-weight: bold } /* Name.Function */
.highlight .nl { color: #336699; font-style: italic } /* Name.Label */
.highlight .nn { color: #bb0066; font-weight: bold } /* Name.Namespace */
.highlight .py { color: #336699; font-weight: bold } /* Name.Property */
.highlight .nt { color: #bb0066; font-weight: bold } /* Name.Tag */
.highlight .nv { color: #336699 } /* Name.Variable */
.highlight .ow { color: #008800 } /* Operator.Word */
.highlight .w { color: #bbbbbb } /* Text.Whitespace */
.highlight .mb { color: #0000DD; font-weight: bold } /* Literal.Number.Bin */
.highlight .mf { color: #0000DD; font-weight: bold } /* Literal.Number.Float */
.highlight .mh { color: #0000DD; font-weight: bold } /* Literal.Number.Hex */
.highlight .mi { color: #0000DD; font-weight: bold } /* Literal.Number.Integer */
.highlight .mo { color: #0000DD; font-weight: bold } /* Literal.Number.Oct */
.highlight .sa { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Affix */
.highlight .sb { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Backtick */
.highlight .sc { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Char */
.highlight .dl { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Delimiter */
.highlight .sd { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Doc */
.highlight .s2 { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Double */
.highlight .se { color: #0044dd; background-color: #fff0f0 } /* Literal.String.Escape */
.highlight .sh { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Heredoc */
.highlight .si { color: #3333bb; background-color: #fff0f0 } /* Literal.String.Interpol */
.highlight .sx { color: #22bb22; background-color: #f0fff0 } /* Literal.String.Other */
.highlight .sr { color: #008800; background-color: #fff0ff } /* Literal.String.Regex */
.highlight .s1 { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Single */
.highlight .ss { color: #aa6600; background-color: #fff0f0 } /* Literal.String.Symbol */
.highlight .bp { color: #003388 } /* Name.Builtin.Pseudo */
.highlight .fm { color: #0066bb; font-weight: bold } /* Name.Function.Magic */
.highlight .vc { color: #336699 } /* Name.Variable.Class */
.highlight .vg { color: #dd7700 } /* Name.Variable.Global */
.highlight .vi { color: #3333bb } /* Name.Variable.Instance */
.highlight .vm { color: #336699 } /* Name.Variable.Magic */
.highlight .il { color: #0000DD; font-weight: bold } /* Literal.Number.Integer.Long */</style><div class="highlight"><pre><span></span>From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= &lt;zajec5@gmail.com&gt;
Date: Thu, 9 Jul 2015 00:07:59 +0200
Subject: [PATCH] brcmfmac: workaround bug with some inconsistent BSSes state
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Rafał Miłecki &lt;zajec5@gmail.com&gt;
<span class="gd">---</span>

<span class="gd">--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c</span>
<span class="gi">+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c</span>
<span class="gu">@@ -665,9 +665,37 @@ static struct wireless_dev *brcmf_cfg802</span>
 						     u32 *flags,
 						     struct vif_params *params)
 {
<span class="gi">+	struct net_device *dev;</span>
 	struct wireless_dev *wdev;
 	int err;
 
<span class="gi">+	/*</span>
<span class="gi">+	 * There is a bug with in-firmware BSS management. When adding virtual</span>
<span class="gi">+	 * interface brcmfmac first tells firmware to create new BSS and then</span>
<span class="gi">+	 * it creates new struct net_device.</span>
<span class="gi">+	 *</span>
<span class="gi">+	 * If creating/registering netdev(ice) fails, BSS remains in some bugged</span>
<span class="gi">+	 * state. It conflicts with existing BSSes by overtaking their auth</span>
<span class="gi">+	 * requests.</span>
<span class="gi">+	 *</span>
<span class="gi">+	 * It results in one BSS (addresss X) sending beacons and another BSS</span>
<span class="gi">+	 * (address Y) replying to authentication requests. This makes interface</span>
<span class="gi">+	 * unusable as AP.</span>
<span class="gi">+	 *</span>
<span class="gi">+	 * To workaround this bug we may try to guess if register_netdev(ice)</span>
<span class="gi">+	 * will fail. The most obvious case is using interface name that already</span>
<span class="gi">+	 * exists. This is actually quite likely with brcmfmac &amp; some user space</span>
<span class="gi">+	 * scripts as brcmfmac doesn&#39;t allow deleting virtual interfaces.</span>
<span class="gi">+	 * So this bug can be triggered even by something trivial like:</span>
<span class="gi">+	 * iw dev wlan0 delete</span>
<span class="gi">+	 * iw phy phy0 interface add wlan0 type __ap</span>
<span class="gi">+	 */</span>
<span class="gi">+	dev = dev_get_by_name(&amp;init_net, name);</span>
<span class="gi">+	if (dev) {</span>
<span class="gi">+		dev_put(dev);</span>
<span class="gi">+		return ERR_PTR(-ENFILE);</span>
<span class="gi">+	}</span>
<span class="gi">+</span>
 	brcmf_dbg(TRACE, &quot;enter: %s type %d\n&quot;, name, type);
 	err = brcmf_vif_add_validate(wiphy_to_cfg(wiphy), type);
 	if (err) {
</pre></div>
</code></pre></td></tr></table>
</div> <!-- class=content -->
<div class='footer'>generated by <a href='https://git.zx2c4.com/cgit/about/'>cgit v1.2.3</a> (<a href='https://git-scm.com/'>git 2.25.1</a>) at 2024-11-13 06:46:56 +0000</div>
</div> <!-- id=cgit -->
</body>
</html>
