diff options
| author | Christian Lamparter <chunkeey@gmail.com> | 2020-08-13 18:26:19 +0200 |
|---|---|---|
| committer | Christian Lamparter <chunkeey@gmail.com> | 2021-10-22 21:25:18 +0200 |
| commit | 8b0c053671e5fb7f36c123a281c51a8071bf96e3 (patch) | |
| tree | a0a6816131fed9d37221da6e25f5ec0c6eef1815 /target/linux/apm821xx/dts/wd-mybooklive.dts | |
| parent | e9335c292003e15901ef5f665750f9493132eb28 (diff) | |
| download | upstream-8b0c053671e5fb7f36c123a281c51a8071bf96e3.tar.gz upstream-8b0c053671e5fb7f36c123a281c51a8071bf96e3.tar.bz2 upstream-8b0c053671e5fb7f36c123a281c51a8071bf96e3.zip | |
apm821xx: implement new LED label naming scheme
This patch updates all current APM82181 devices over to that
"new LED naming scheme". This includes many updates to the
device-tree:
- dropped the deprecated, but beloved "label" property.
- rename all DT leds node names to led-#.
- add function and color properties.
- utilized panic-indicator property.
- dropped led- aliases (see below).
migration scripts for all devices are included.
For more information. See:
<https://www.kernel.org/doc/html/latest/leds/leds-class.html>
For the future: It looks like the color+function properties
won over the dt-alias / label. This will need to be wired up
into openwrt eventually. For APM821xx the situation is that
all devices have a dedicated power and fault indicator.
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
Diffstat (limited to 'target/linux/apm821xx/dts/wd-mybooklive.dts')
| -rw-r--r-- | target/linux/apm821xx/dts/wd-mybooklive.dts | 26 |
1 files changed, 15 insertions, 11 deletions
diff --git a/target/linux/apm821xx/dts/wd-mybooklive.dts b/target/linux/apm821xx/dts/wd-mybooklive.dts index bccf82fbaa..c96e7f75e9 100644 --- a/target/linux/apm821xx/dts/wd-mybooklive.dts +++ b/target/linux/apm821xx/dts/wd-mybooklive.dts @@ -6,6 +6,7 @@ /dts-v1/; +#include <dt-bindings/leds/common.h> #include "apm82181.dtsi" / { @@ -14,10 +15,6 @@ aliases { serial0 = &UART0; - led-boot = &status; - led-failsafe = &status; - led-running = &status; - led-upgrade = &status; }; }; @@ -86,19 +83,26 @@ leds { compatible = "gpio-leds"; - failsafe: power-red { - label = "mbl:red:power"; + /* There's just one tri-color LED with three separate pins. + * One pin for each color (red, green and blue). Each has + * a different meaning. + */ + led-0 { + color = <LED_COLOR_ID_RED>; + function = LED_FUNCTION_FAULT; gpios = <&GPIO1 4 GPIO_ACTIVE_HIGH>; - linux,default-trigger = "panic"; + panic-indicator; }; - status: power-green { - label = "mbl:green:power"; + led-1 { + color = <LED_COLOR_ID_GREEN>; + function = LED_FUNCTION_POWER; gpios = <&GPIO1 5 GPIO_ACTIVE_HIGH>; }; - power-blue { - label = "mbl:blue:power"; + led-2 { + color = <LED_COLOR_ID_BLUE>; + function = LED_FUNCTION_DISK; gpios = <&GPIO1 6 GPIO_ACTIVE_HIGH>; linux,default-trigger = "disk-activity"; }; |