diff options
| author | Florian Fainelli <florian@openwrt.org> | 2007-01-08 10:00:49 +0000 |
|---|---|---|
| committer | Florian Fainelli <florian@openwrt.org> | 2007-01-08 10:00:49 +0000 |
| commit | 240ac0c4e74ceaa07173bd0b820cd51215bd057d (patch) | |
| tree | 133af50bc009ce25afa2b8cbe9fdbaed86cf71db /docs/bugs.tex | |
| parent | ff547e1620e84f2c8016777c160bbc208f99a338 (diff) | |
| download | upstream-240ac0c4e74ceaa07173bd0b820cd51215bd057d.tar.gz upstream-240ac0c4e74ceaa07173bd0b820cd51215bd057d.tar.bz2 upstream-240ac0c4e74ceaa07173bd0b820cd51215bd057d.zip | |
Add a "submitting patches" subsection
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@6031 3c298f89-4303-0410-b956-a3cf2f4a3e73
Diffstat (limited to 'docs/bugs.tex')
| -rw-r--r-- | docs/bugs.tex | 20 |
1 files changed, 15 insertions, 5 deletions
diff --git a/docs/bugs.tex b/docs/bugs.tex index 9f0f4f0b3a..b4f502ce49 100644 --- a/docs/bugs.tex +++ b/docs/bugs.tex @@ -29,15 +29,25 @@ Regarding the kind of ticket that is open, a patch is welcome in those cases: \item new features that can be added by modifying existing OpenWrt files \end{itemize} -In order to include a patch, you need to produce it, this can be done by using the -\textbf{svn diff} command which generates the differences between your local copy -(modified) and the version on the OpenWrt repository (unmodified yet). Then attach -the patch with a description, using the "Attach" button. - Once the ticket is open, a developer will take care of it, if so, the ticket is marked as "accepted" with the developer name. You can add comments at any time to the ticket, even when it is closed. +\subsubsection{Submitting patches} + +In order to include a patch to a ticket, you need to output it, this can be done by using the \textbf{svn diff} command which generates the differences between your local copy (modified) and the version on the OpenWrt repository (unmodified yet). Then attach the patch with a description, using the "Attach" button. + +Your patch must respect the following conventions : + +\begin{itemize} +\item it has to work, with no side effect on other platforms, distributions, packages ... +\item it must have a reason to be included in OpenWrt : bug fix, enhancement, feature adding/removing +\item the patch name should be named like that : <index number>-this\_fixes\_bug\_foo\_and\_bar.patch +\item if several, they have to be indexed with an integer number : 100-patch1, 200-patch2 ... +\end{itemize} + +Your patch will be read and most likely be used as-is by the developpers if it is clean and working. If not, the patch will be accepted anyway and modified to be OpenWrt-rules compliant + \subsubsection{Closing a ticket} A ticket might be closed by a developer because: |