diff options
| author | Rosen Penev <rosenp@gmail.com> | 2018-10-31 16:55:14 -0700 |
|---|---|---|
| committer | Hauke Mehrtens <hauke@hauke-m.de> | 2018-11-01 17:16:52 +0100 |
| commit | 32fc41baabc9e83a045a7a805b0d91a030cfbd3c (patch) | |
| tree | 7b2e4f77649a5466d216b5976a7d455db9391b66 | |
| parent | f9a408b75e72d9ddbe4ddf9e54bad2b4b604235a (diff) | |
| download | upstream-32fc41baabc9e83a045a7a805b0d91a030cfbd3c.tar.gz upstream-32fc41baabc9e83a045a7a805b0d91a030cfbd3c.tar.bz2 upstream-32fc41baabc9e83a045a7a805b0d91a030cfbd3c.zip | |
tools/patch: Add fedora patch for crashing git style patches
https://lists.gnu.org/archive/html/bug-patch/2018-10/msg00000.html
I assume a CVE number will be assigned soon.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
| -rw-r--r-- | tools/patch/Makefile | 2 | ||||
| -rw-r--r-- | tools/patch/patches/040-Fix-error-handling-with-git-style-patches.patch | 53 |
2 files changed, 54 insertions, 1 deletions
diff --git a/tools/patch/Makefile b/tools/patch/Makefile index 7323b5b2ab..cab9fee9f6 100644 --- a/tools/patch/Makefile +++ b/tools/patch/Makefile @@ -8,7 +8,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=patch PKG_VERSION:=2.7.6 -PKG_RELEASE:=3 +PKG_RELEASE:=4 PKG_CPE_ID:=cpe:/a:gnu:patch PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz diff --git a/tools/patch/patches/040-Fix-error-handling-with-git-style-patches.patch b/tools/patch/patches/040-Fix-error-handling-with-git-style-patches.patch new file mode 100644 index 0000000000..5cc958e746 --- /dev/null +++ b/tools/patch/patches/040-Fix-error-handling-with-git-style-patches.patch @@ -0,0 +1,53 @@ +From 424da221cec76ea200cff1fa9b08a6f3d94c28a7 Mon Sep 17 00:00:00 2001 +From: Lubomir Rintel <lkundrak@v3.sk> +Date: Wed, 31 Oct 2018 16:39:13 -0700 +Subject: [PATCH] Fix error handling with git-style patches + +When an error is encountered in output_files(), the subsequent call to +cleanup() calls back into output_files() resulting in an infinte recursion. +This is trivially reproduced with a git-style patch (which utilizes +output_file_later()) that tries to patch a nonexistent or unreadable +file (see attached test case). + +* src/patch.c: (output_files) clear the files_to_output list before +iterating it, so that recursive calls won't iterate the same files. +--- + src/patch.c | 12 ++++++++---- + 1 file changed, 8 insertions(+), 4 deletions(-) + +--- a/src/patch.c ++++ b/src/patch.c +@@ -1938,8 +1938,12 @@ output_files (struct stat const *st) + { + gl_list_iterator_t iter; + const void *elt; ++ gl_list_t files; + +- iter = gl_list_iterator (files_to_output); ++ files = files_to_output; ++ init_files_to_output (); ++ ++ iter = gl_list_iterator (files); + while (gl_list_iterator_next (&iter, &elt, NULL)) + { + const struct file_to_output *file_to_output = elt; +@@ -1957,8 +1961,8 @@ output_files (struct stat const *st) + /* Free the list up to here. */ + for (;;) + { +- const void *elt2 = gl_list_get_at (files_to_output, 0); +- gl_list_remove_at (files_to_output, 0); ++ const void *elt2 = gl_list_get_at (files, 0); ++ gl_list_remove_at (files, 0); + if (elt == elt2) + break; + } +@@ -1967,7 +1971,7 @@ output_files (struct stat const *st) + } + } + gl_list_iterator_free (&iter); +- gl_list_clear (files_to_output); ++ gl_list_clear (files); + } + + /* Fatal exit with cleanup. */ |