From f6e30f22f4334c36a42622e8fddd9cd92d0fe543 Mon Sep 17 00:00:00 2001 From: whitequark Date: Wed, 1 Jul 2020 20:22:21 +0000 Subject: CMake: fix path checks in chipdb build scripts. `if(NOT DEFINED)` is not appropriate since a variable that contains `-NOTFOUND` still counts as `DEFINED`. This can cause issues if configuration fails, writes `-NOTFOUND` to the cache, and is then restarted. --- ecp5/CMakeLists.txt | 4 ++-- ice40/CMakeLists.txt | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ecp5/CMakeLists.txt b/ecp5/CMakeLists.txt index 303208ed..5bb82f4c 100644 --- a/ecp5/CMakeLists.txt +++ b/ecp5/CMakeLists.txt @@ -25,7 +25,7 @@ else() "Trellis install prefix") message(STATUS "Trellis install prefix: ${TRELLIS_INSTALL_PREFIX}") - if(NOT DEFINED TRELLIS_LIBDIR) + if(NOT TRELLIS_LIBDIR) if(WIN32) set(pytrellis_lib pytrellis.pyd) else() @@ -42,7 +42,7 @@ else() endif() message(STATUS "Trellis library directory: ${TRELLIS_LIBDIR}") - if(NOT DEFINED TRELLIS_DATADIR) + if(NOT TRELLIS_DATADIR) set(TRELLIS_DATADIR ${TRELLIS_INSTALL_PREFIX}/share/${TRELLIS_PROGRAM_PREFIX}trellis) endif() message(STATUS "Trellis data directory: ${TRELLIS_DATADIR}") diff --git a/ice40/CMakeLists.txt b/ice40/CMakeLists.txt index 1bf64905..89203bbc 100644 --- a/ice40/CMakeLists.txt +++ b/ice40/CMakeLists.txt @@ -27,7 +27,7 @@ else() "IceStorm install prefix") message(STATUS "IceStorm install prefix: ${ICESTORM_INSTALL_PREFIX}") - if(NOT DEFINED ICEBOX_DATADIR) + if(NOT ICEBOX_DATADIR) set(ICEBOX_DATADIR ${ICESTORM_INSTALL_PREFIX}/share/icebox) endif() message(STATUS "icebox data directory: ${ICEBOX_DATADIR}") -- cgit v1.2.3 From 18bb70afca9cf4100e3230a12e9df1df99e43306 Mon Sep 17 00:00:00 2001 From: whitequark Date: Wed, 1 Jul 2020 20:32:52 +0000 Subject: CMake: improve logic for discovering Trellis. --- ecp5/CMakeLists.txt | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/ecp5/CMakeLists.txt b/ecp5/CMakeLists.txt index 5bb82f4c..fe7de587 100644 --- a/ecp5/CMakeLists.txt +++ b/ecp5/CMakeLists.txt @@ -26,14 +26,38 @@ else() message(STATUS "Trellis install prefix: ${TRELLIS_INSTALL_PREFIX}") if(NOT TRELLIS_LIBDIR) + # The pytrellis library isn't a normal shared library, but rather a native Python library; + # it does not follow the normal platform conventions for shared libraries, so we can't just + # use find_library() here. Instead, we emulate the useful parts of the find_library() logic + # for use with find_path(). + set(pytrellis_paths) + foreach(prefix_path ${CMAKE_PREFIX_PATH}) + list(APPEND pytrellis_paths ${prefix_path}/lib) + if(CMAKE_LIBRARY_ARCHITECTURE) + list(APPEND pytrellis_paths ${prefix_path}/lib/${CMAKE_LIBRARY_ARCHITECTURE}) + endif() + endforeach() + list(APPEND pytrellis_paths ${CMAKE_LIBRARY_PATH}) + if(NOT NO_CMAKE_SYSTEM_PATH) + foreach(prefix_path ${CMAKE_SYSTEM_PREFIX_PATH}) + list(APPEND pytrellis_paths ${prefix_path}/lib) + if(CMAKE_LIBRARY_ARCHITECTURE) + list(APPEND pytrellis_paths ${prefix_path}/lib/${CMAKE_LIBRARY_ARCHITECTURE}) + endif() + endforeach() + list(APPEND pytrellis_paths ${CMAKE_SYSTEM_LIBRARY_PATH}) + endif() + message(STATUS "Searching for pytrellis in: ${pytrellis_paths}") + if(WIN32) set(pytrellis_lib pytrellis.pyd) else() set(pytrellis_lib pytrellis${CMAKE_SHARED_LIBRARY_SUFFIX}) endif() + find_path(TRELLIS_LIBDIR ${pytrellis_lib} HINTS ${TRELLIS_INSTALL_PREFIX}/lib/${TRELLIS_PROGRAM_PREFIX}trellis - PATHS ${CMAKE_SYSTEM_LIBRARY_PATH} ${CMAKE_LIBRARY_PATH} + PATHS ${pytrellis_paths} PATH_SUFFIXES ${TRELLIS_PROGRAM_PREFIX}trellis DOC "Location of the pytrellis library") if(NOT TRELLIS_LIBDIR) -- cgit v1.2.3