From 961f4a1f29787cbb6bd9a8a43b6ac4f3f0d024c0 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Fri, 4 Oct 2019 17:34:22 +0200 Subject: Fix more sign-compare issues The one in the `dummyflasher` is a little peculiar. We actually never knew the type of the `st_size` field in `struct stat`. It happens to be `signed` in some systems (e.g. DJGPP). Change-Id: If36ba22606021400b385ea6083eacc7b360c20c5 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/flashrom/+/35800 Tested-by: build bot (Jenkins) Reviewed-by: Jacob Garber Reviewed-by: Patrick Georgi --- ich_descriptors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'ich_descriptors.c') diff --git a/ich_descriptors.c b/ich_descriptors.c index 6d7b020a..120d3fea 100644 --- a/ich_descriptors.c +++ b/ich_descriptors.c @@ -421,7 +421,7 @@ void prettyprint_ich_descriptor_master(const enum ich_chipset cs, const struct i for (i = 0; i < nm; i++) { size_t j; msg_pdbg2("%-4s", master_names[i]); - for (j = 0; j < min(num_regions, 12); j++) + for (j = 0; j < (size_t)min(num_regions, 12); j++) msg_pdbg2(" %c%c ", desc->master.mstr[i].read & (1 << j) ? 'r' : ' ', desc->master.mstr[i].write & (1 << j) ? 'w' : ' '); -- cgit v1.2.3