From e276411e82588e93a8578b5eadd672ecd35058ee Mon Sep 17 00:00:00 2001 From: Elyes HAOUAS Date: Sun, 9 Jun 2019 17:09:25 +0200 Subject: fmap.c: Remove unneeded 'else' 'else' is not needed after a 'break' or 'return'. Change-Id: I5df4d8075be012b9edf7be520d611042d9945094 Signed-off-by: Elyes HAOUAS Reviewed-on: https://review.coreboot.org/c/flashrom/+/33345 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- fmap.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/fmap.c b/fmap.c index 84b3b549..31f282fd 100644 --- a/fmap.c +++ b/fmap.c @@ -132,9 +132,8 @@ int fmap_read_from_buffer(struct fmap **fmap_out, const uint8_t *const buf, size if (offset < 0) { msg_gdbg("Unable to find fmap in provided buffer.\n"); return 2; - } else { - msg_gdbg("Found fmap at offset 0x%06zx\n", (size_t)offset); } + msg_gdbg("Found fmap at offset 0x%06zx\n", (size_t)offset); const struct fmap *fmap = (const struct fmap *)(buf + offset); *fmap_out = malloc(fmap_size(fmap)); @@ -251,10 +250,9 @@ static int fmap_bsearch_rom(struct fmap **fmap_out, struct flashctx *const flash msg_gdbg("fmap found at offset 0x%06zx\n", offset); fmap_found = 1; break; - } else { - msg_gerr("fmap signature found at %zu but header is invalid.\n", offset); - ret = 2; } + msg_gerr("fmap signature found at %zu but header is invalid.\n", offset); + ret = 2; } if (fmap_found) -- cgit v1.2.3