From 98534e717bc457ea41a3bdf6e1d677fb0c1f63ca Mon Sep 17 00:00:00 2001 From: Anastasia Klimchuk Date: Fri, 23 Apr 2021 15:47:03 +1000 Subject: tests: Add unit test to run init/shutdown for linux_spi.c The current implementation tests a particular path of the init procedure. There are two ways for it to succeed: reading the buffer size from sysfs and the fallback to getpagesize(). This test does the latter (fallback to getpagesize). Extract from meson-logs/testlog.txt for new test: [ RUN ] linux_spi_init_and_shutdown_test_success Testing programmer_init for programmer=25 ... __wrap_open64 is called __wrap_ioctl is called __wrap_ioctl is called __wrap_ioctl is called __wrap_fopen64 is called ... programmer_init for programmer=25 successful Testing programmer_shutdown for programmer=25 ... ... programmer_shutdown for programmer=25 successful [ OK ] linux_spi_init_and_shutdown_test_success BUG=b:181803212 TEST=builds and ninja test Change-Id: I4911fbb6f04371283f0e62d2196bdd691a227584 Signed-off-by: Anastasia Klimchuk Reviewed-on: https://review.coreboot.org/c/flashrom/+/52498 Reviewed-by: Nico Huber Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- tests/init_shutdown.c | 11 +++++++++++ tests/meson.build | 7 +++++++ tests/tests.c | 43 +++++++++++++++++++++++++++++++++++++++++++ tests/tests.h | 1 + 4 files changed, 62 insertions(+) diff --git a/tests/init_shutdown.c b/tests/init_shutdown.c index 52268601..abaaf682 100644 --- a/tests/init_shutdown.c +++ b/tests/init_shutdown.c @@ -35,3 +35,14 @@ void dummy_init_and_shutdown_test_success(void **state) { run_lifecycle(state, PROGRAMMER_DUMMY, "bus=parallel+lpc+fwh+spi"); } + +void linux_spi_init_and_shutdown_test_success(void **state) +{ + /* + * Current implementation tests a particular path of the init procedure. + * There are two ways for it to succeed: reading the buffer size from sysfs + * and the fallback to getpagesize(). This test does the latter (fallback to + * getpagesize). + */ + run_lifecycle(state, PROGRAMMER_LINUX_SPI, "dev=/dev/null"); +} diff --git a/tests/meson.build b/tests/meson.build index 815ea766..b087f2ce 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -25,6 +25,13 @@ mocks = [ '-Wl,--wrap=physunmap', '-Wl,--wrap=physmap', '-Wl,--wrap=spi_send_command', + '-Wl,--wrap=sio_write', + '-Wl,--wrap=sio_read', + '-Wl,--wrap=open', + '-Wl,--wrap=open64', + '-Wl,--wrap=ioctl', + '-Wl,--wrap=fopen', + '-Wl,--wrap=fopen64', '-Wl,--gc-sections', ] diff --git a/tests/tests.c b/tests/tests.c index 1dc819ed..701770f4 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -17,6 +17,7 @@ #include "tests.h" #include +#include /* redefinitions/wrapping */ #define LOG_ME printf("%s is called\n", __func__) @@ -32,6 +33,47 @@ void *__wrap_physmap(const char *descr, uintptr_t phys_addr, size_t len) return NULL; } +void __wrap_sio_write(uint16_t port, uint8_t reg, uint8_t data) +{ + LOG_ME; +} + +uint8_t __wrap_sio_read(uint16_t port, uint8_t reg) +{ + LOG_ME; + return (uint8_t)mock(); +} + +int __wrap_open(const char *pathname, int flags) +{ + LOG_ME; + return 2021; +} + +int __wrap_open64(const char *pathname, int flags) +{ + LOG_ME; + return 2021; +} + +int __wrap_ioctl(int fd, unsigned long int request, ...) +{ + LOG_ME; + return 2021; +} + +FILE *__wrap_fopen(const char *pathname, const char *mode) +{ + LOG_ME; + return NULL; +} + +FILE *__wrap_fopen64(const char *pathname, const char *mode) +{ + LOG_ME; + return NULL; +} + int main(void) { int ret = 0; @@ -70,6 +112,7 @@ int main(void) const struct CMUnitTest init_shutdown_tests[] = { cmocka_unit_test(dummy_init_and_shutdown_test_success), + cmocka_unit_test(linux_spi_init_and_shutdown_test_success), }; ret |= cmocka_run_group_tests_name("init_shutdown.c tests", init_shutdown_tests, NULL, NULL); diff --git a/tests/tests.h b/tests/tests.h index 32fed0a4..16476c27 100644 --- a/tests/tests.h +++ b/tests/tests.h @@ -42,5 +42,6 @@ void probe_spi_st95_test_success(void **state); /* spi95.c */ /* init_shutdown.c */ void dummy_init_and_shutdown_test_success(void **state); +void linux_spi_init_and_shutdown_test_success(void **state); #endif /* TESTS_H */ -- cgit v1.2.3