From 91c10aebb35893fdabb2d094155745468b90b5f5 Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Fri, 9 Oct 2020 12:56:53 +1100 Subject: dediprog.c: Fix layering violation of default_spi_read default_spi_read() calls spi_read_chunked() with the correct max_read value of 16 set in the spi master struct. Change-Id: Ic0897f74056e3d723a33c063ed0bd8cb6e88ba45 Signed-off-by: Edward O'Callaghan Reviewed-on: https://review.coreboot.org/c/flashrom/+/46232 Reviewed-by: Angel Pons Reviewed-by: Sam McNally Tested-by: build bot (Jenkins) --- dediprog.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dediprog.c b/dediprog.c index 827d5e49..a9d00349 100644 --- a/dediprog.c +++ b/dediprog.c @@ -545,7 +545,7 @@ static int dediprog_spi_read(struct flashctx *flash, uint8_t *buf, unsigned int if (residue) { msg_pdbg("Slow read for partial block from 0x%x, length 0x%x\n", start, residue); - ret = spi_read_chunked(flash, buf, start, residue, 16); + ret = default_spi_read(flash, buf, start, residue); if (ret) goto err; } @@ -560,8 +560,8 @@ static int dediprog_spi_read(struct flashctx *flash, uint8_t *buf, unsigned int if (len != 0) { msg_pdbg("Slow read for partial block from 0x%x, length 0x%x\n", start, len); - ret = spi_read_chunked(flash, buf + residue + bulklen, - start + residue + bulklen, len, 16); + ret = default_spi_read(flash, buf + residue + bulklen, + start + residue + bulklen, len); if (ret) goto err; } -- cgit v1.2.3