From 1b172f2da5573bd8b1732921af1b25a2cc739572 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Mon, 19 Jun 2017 12:35:24 +0200 Subject: fixup! Add a convenient libflashrom interface The buffer passed to flashrom_image_write() isn't `const`. It might be altered for full verification (with mixed contents if a layout is being used). Change-Id: Ibd8a9579e5dd859ae03b0deb3042b7035719e5de Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/20266 Tested-by: build bot (Jenkins) Reviewed-by: David Hendricks --- flashrom.c | 2 +- libflashrom.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/flashrom.c b/flashrom.c index 503a1990..838dfd05 100644 --- a/flashrom.c +++ b/flashrom.c @@ -2294,7 +2294,7 @@ static void combine_image_by_layout(const struct flashctx *const flashctx, * containing included regions will be touched. * * @param flashctx The context of the flash chip. - * @param buffer Source buffer to read image from. + * @param buffer Source buffer to read image from (may be altered for full verification). * @param buffer_len Size of source buffer in bytes. * @return 0 on success, * 4 if buffer_len doesn't match the size of the flash chip, diff --git a/libflashrom.h b/libflashrom.h index 1937194f..09a88c41 100644 --- a/libflashrom.h +++ b/libflashrom.h @@ -59,7 +59,7 @@ void flashrom_flag_set(struct flashrom_flashctx *, enum flashrom_flag, bool valu bool flashrom_flag_get(const struct flashrom_flashctx *, enum flashrom_flag); int flashrom_image_read(struct flashrom_flashctx *, void *buffer, size_t buffer_len); -int flashrom_image_write(struct flashrom_flashctx *, const void *buffer, size_t buffer_len); +int flashrom_image_write(struct flashrom_flashctx *, void *buffer, size_t buffer_len); int flashrom_image_verify(struct flashrom_flashctx *, const void *buffer, size_t buffer_len); struct flashrom_layout; -- cgit v1.2.3