From 6a41122990017491222602753441de8ac438b735 Mon Sep 17 00:00:00 2001 From: Maximilian Hils Date: Sun, 30 Jul 2017 02:14:44 +0200 Subject: make option redeclaration silent if signature is the same --- test/mitmproxy/test_addonmanager.py | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'test') diff --git a/test/mitmproxy/test_addonmanager.py b/test/mitmproxy/test_addonmanager.py index 5bff61d1..67b766fa 100644 --- a/test/mitmproxy/test_addonmanager.py +++ b/test/mitmproxy/test_addonmanager.py @@ -91,7 +91,15 @@ def test_loader(): with taddons.context() as tctx: l = addonmanager.Loader(tctx.master) l.add_option("custom_option", bool, False, "help") + assert "custom_option" in l.master.options + + # calling this again with the same signature is a no-op. l.add_option("custom_option", bool, False, "help") + assert not tctx.master.has_log("Over-riding existing option") + + # a different signature should emit a warning though. + l.add_option("custom_option", bool, True, "help") + assert tctx.master.has_log("Over-riding existing option") def cmd(a: str) -> str: return "foo" -- cgit v1.2.3