From 4c7f99d2bedb299063a519519504768c710a58ee Mon Sep 17 00:00:00 2001
From: Thomas Kriechbaumer <thomas@kriechbaumer.name>
Date: Sat, 3 Sep 2016 15:01:41 +0200
Subject: improve netlib.encoding

---
 test/netlib/test_encoding.py | 49 ++++++++++++++++----------------------------
 1 file changed, 18 insertions(+), 31 deletions(-)

(limited to 'test/netlib/test_encoding.py')

diff --git a/test/netlib/test_encoding.py b/test/netlib/test_encoding.py
index 08e69ec5..b191d50d 100644
--- a/test/netlib/test_encoding.py
+++ b/test/netlib/test_encoding.py
@@ -1,4 +1,6 @@
 import mock
+import pytest
+
 from netlib import encoding, tutils
 
 
@@ -9,47 +11,32 @@ def test_identity():
         encoding.encode(b"string", "nonexistent encoding")
 
 
-def test_gzip():
-    assert b"string" == encoding.decode(
-        encoding.encode(
-            b"string",
-            "gzip"
-        ),
-        "gzip"
-    )
-    with tutils.raises(ValueError):
-        encoding.decode(b"bogus", "gzip")
+@pytest.mark.parametrize("encoder", [
+    'gzip',
+    'br',
+    'deflate',
+])
+def test_encoders(encoder):
+    assert "" == encoding.decode("", encoder)
+    assert b"" == encoding.decode(b"", encoder)
 
-
-def test_brotli():
-    assert b"string" == encoding.decode(
+    assert "string" == encoding.decode(
         encoding.encode(
-            b"string",
-            "br"
+            "string",
+            encoder
         ),
-        "br"
+        encoder
     )
-    with tutils.raises(ValueError):
-        encoding.decode(b"bogus", "br")
-
-
-def test_deflate():
     assert b"string" == encoding.decode(
         encoding.encode(
             b"string",
-            "deflate"
+            encoder
         ),
-        "deflate"
-    )
-    assert b"string" == encoding.decode(
-        encoding.encode(
-            b"string",
-            "deflate"
-        )[2:-4],
-        "deflate"
+        encoder
     )
+
     with tutils.raises(ValueError):
-        encoding.decode(b"bogus", "deflate")
+        encoding.decode(b"bogus", encoder)
 
 
 def test_cache():
-- 
cgit v1.2.3


From c0b12da40108899d9bf470d14a460f6ca4efaa5d Mon Sep 17 00:00:00 2001
From: Thomas Kriechbaumer <thomas@kriechbaumer.name>
Date: Sat, 3 Sep 2016 16:37:03 +0200
Subject: change test value

---
 test/netlib/test_encoding.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'test/netlib/test_encoding.py')

diff --git a/test/netlib/test_encoding.py b/test/netlib/test_encoding.py
index b191d50d..797abff2 100644
--- a/test/netlib/test_encoding.py
+++ b/test/netlib/test_encoding.py
@@ -36,7 +36,7 @@ def test_encoders(encoder):
     )
 
     with tutils.raises(ValueError):
-        encoding.decode(b"bogus", encoder)
+        encoding.decode(b"foobar", encoder)
 
 
 def test_cache():
-- 
cgit v1.2.3