From a5f1215eb2a17dcc25b1b171d3550a4474e71214 Mon Sep 17 00:00:00 2001
From: chhsiao90 <chhsiao90@gmail.com>
Date: Fri, 30 Dec 2016 21:03:22 +0800
Subject: Allow underscore in hostname

---
 mitmproxy/net/check.py           | 3 ++-
 test/mitmproxy/net/test_check.py | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/mitmproxy/net/check.py b/mitmproxy/net/check.py
index 7b007cb5..f793d397 100644
--- a/mitmproxy/net/check.py
+++ b/mitmproxy/net/check.py
@@ -1,6 +1,7 @@
 import re
 
-_label_valid = re.compile(b"(?!-)[A-Z\d-]{1,63}(?<!-)$", re.IGNORECASE)
+# Allow underscore in host name
+_label_valid = re.compile(b"(?!-)[A-Z\d\-_]{1,63}(?<!-)$", re.IGNORECASE)
 
 
 def is_valid_host(host: bytes) -> bool:
diff --git a/test/mitmproxy/net/test_check.py b/test/mitmproxy/net/test_check.py
index 18a50157..36dca168 100644
--- a/test/mitmproxy/net/test_check.py
+++ b/test/mitmproxy/net/test_check.py
@@ -8,3 +8,5 @@ def test_is_valid_host():
     assert check.is_valid_host(b"one.two")
     assert not check.is_valid_host(b"one" * 255)
     assert check.is_valid_host(b"one.two.")
+    # Allow underscore
+    assert check.is_valid_host(b"one_two")
-- 
cgit v1.2.3