From 3b95cd7f563809c136205c0642b4d54395e6b2eb Mon Sep 17 00:00:00 2001 From: Paul Kehrer Date: Tue, 22 Dec 2015 21:40:20 -0600 Subject: CRLNumber needs to be a class for reasons. --- tests/test_x509.py | 2 +- tests/test_x509_ext.py | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) (limited to 'tests') diff --git a/tests/test_x509.py b/tests/test_x509.py index b39e1891..ae2746e3 100644 --- a/tests/test_x509.py +++ b/tests/test_x509.py @@ -192,7 +192,7 @@ class TestCertificateRevocationList(object): ian = crl.extensions.get_extension_for_class( x509.IssuerAlternativeName ) - assert crl_number.value == 1 + assert crl_number.value == x509.CRLNumber(1) assert crl_number.critical is False assert aki.value == x509.AuthorityKeyIdentifier( key_identifier=( diff --git a/tests/test_x509_ext.py b/tests/test_x509_ext.py index 83145cd0..4b1d6a5a 100644 --- a/tests/test_x509_ext.py +++ b/tests/test_x509_ext.py @@ -1488,6 +1488,21 @@ class TestRSAIssuerAlternativeNameExtension(object): ] +class TestCRLNumber(object): + def test_eq(self): + crl_number = x509.CRLNumber(15) + assert crl_number == x509.CRLNumber(15) + + def test_ne(self): + crl_number = x509.CRLNumber(15) + assert crl_number != x509.CRLNumber(14) + assert crl_number != object() + + def test_repr(self): + crl_number = x509.CRLNumber(15) + assert repr(crl_number) == "" + + class TestSubjectAlternativeName(object): def test_get_values_for_type(self): san = x509.SubjectAlternativeName( -- cgit v1.2.3 From a9718fce3687a6a787ae8a03b989580dc68be260 Mon Sep 17 00:00:00 2001 From: Paul Kehrer Date: Tue, 22 Dec 2015 22:55:35 -0600 Subject: missed a test for CRLNumber not being an integer, oops --- tests/test_x509_ext.py | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'tests') diff --git a/tests/test_x509_ext.py b/tests/test_x509_ext.py index 4b1d6a5a..d9743c8e 100644 --- a/tests/test_x509_ext.py +++ b/tests/test_x509_ext.py @@ -1502,6 +1502,10 @@ class TestCRLNumber(object): crl_number = x509.CRLNumber(15) assert repr(crl_number) == "" + def test_invalid_number(self): + with pytest.raises(TypeError): + x509.CRLNumber("notanumber") + class TestSubjectAlternativeName(object): def test_get_values_for_type(self): -- cgit v1.2.3