From ba19c2e73f70e5b3e08d62e13326e91588eae8c4 Mon Sep 17 00:00:00 2001 From: Alex Gaynor Date: Sat, 27 Jun 2015 00:07:09 -0400 Subject: Fixed #2067 -- raise an error if a CSRbuilder doesn't hav a subject --- tests/test_x509.py | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) (limited to 'tests') diff --git a/tests/test_x509.py b/tests/test_x509.py index 08dae0ce..131954ca 100644 --- a/tests/test_x509.py +++ b/tests/test_x509.py @@ -687,10 +687,20 @@ class TestCertificateSigningRequestBuilder(object): def test_sign_invalid_hash_algorithm(self, backend): private_key = RSA_KEY_2048.private_key(backend) - builder = x509.CertificateSigningRequestBuilder() + builder = x509.CertificateSigningRequestBuilder().subject_name( + x509.Name([]) + ) with pytest.raises(TypeError): builder.sign(private_key, 'NotAHash', backend) + @pytest.mark.requires_backend_interface(interface=RSABackend) + def test_no_subject_name(self, backend): + private_key = RSA_KEY_2048.private_key(backend) + + builder = x509.CertificateSigningRequestBuilder() + with pytest.raises(ValueError): + builder.sign(private_key, hashes.SHA256(), backend) + @pytest.mark.requires_backend_interface(interface=RSABackend) def test_build_ca_request_with_rsa(self, backend): private_key = RSA_KEY_2048.private_key(backend) -- cgit v1.2.3