diff options
| -rw-r--r-- | .travis.yml | 3 | ||||
| -rwxr-xr-x | ci/travis.sh | 10 | ||||
| -rw-r--r-- | googlemock/cmake/gmock.pc.in | 2 | ||||
| -rw-r--r-- | googlemock/cmake/gmock_main.pc.in | 2 | ||||
| -rw-r--r-- | googlemock/docs/cook_book.md | 4 | ||||
| -rw-r--r-- | googletest/cmake/gtest_main.pc.in | 2 | ||||
| -rw-r--r-- | googletest/src/gtest-port.cc | 2 | ||||
| -rw-r--r-- | googletest/test/googletest-death-test_ex_test.cc | 2 | ||||
| -rw-r--r-- | googletest/test/gtest-unittest-api_test.cc | 8 | 
9 files changed, 16 insertions, 19 deletions
| diff --git a/.travis.yml b/.travis.yml index 04b51dde..27c725c0 100644 --- a/.travis.yml +++ b/.travis.yml @@ -28,9 +28,6 @@ matrix:        env: BUILD_TYPE=Debug VERBOSE=1 CXX_FLAGS=-std=c++11      - os: linux        compiler: clang -      env: BUILD_TYPE=Release VERBOSE=1 CXX_FLAGS=-std=c++11 -Wgnu-zero-variadic-macro-arguments -    - os: linux -      compiler: clang        env: BUILD_TYPE=Release VERBOSE=1 CXX_FLAGS=-std=c++11 NO_EXCEPTION=ON NO_RTTI=ON COMPILER_IS_GNUCXX=ON      - os: osx        compiler: gcc diff --git a/ci/travis.sh b/ci/travis.sh index 9ff3bad3..f37660bb 100755 --- a/ci/travis.sh +++ b/ci/travis.sh @@ -34,11 +34,11 @@ cd build  cmake -Dgtest_build_samples=ON \        -Dgtest_build_tests=ON \        -Dgmock_build_tests=ON \ -      -Dcxx_no_exception=$NO_EXCEPTION \ -      -Dcxx_no_rtti=$NO_RTTI \ -      -DCMAKE_COMPILER_IS_GNUCXX=$COMPILER_IS_GNUCXX \ -      -DCMAKE_CXX_FLAGS=$CXX_FLAGS \ -      -DCMAKE_BUILD_TYPE=$BUILD_TYPE \ +      -Dcxx_no_exception="$NO_EXCEPTION" \ +      -Dcxx_no_rtti="$NO_RTTI" \ +      -DCMAKE_COMPILER_IS_GNUCXX="$COMPILER_IS_GNUCXX" \ +      -DCMAKE_CXX_FLAGS="$CXX_FLAGS" \ +      -DCMAKE_BUILD_TYPE="$BUILD_TYPE" \        ..  make  CTEST_OUTPUT_ON_FAILURE=1 make test diff --git a/googlemock/cmake/gmock.pc.in b/googlemock/cmake/gmock.pc.in index 5780fcaa..23c67b5c 100644 --- a/googlemock/cmake/gmock.pc.in +++ b/googlemock/cmake/gmock.pc.in @@ -5,6 +5,6 @@ Name: gmock  Description: GoogleMock (without main() function)  Version: @PROJECT_VERSION@  URL: https://github.com/google/googletest -Requires: gtest +Requires: gtest = @PROJECT_VERSION@  Libs: -L${libdir} -lgmock @CMAKE_THREAD_LIBS_INIT@  Cflags: -I${includedir} @GTEST_HAS_PTHREAD_MACRO@ diff --git a/googlemock/cmake/gmock_main.pc.in b/googlemock/cmake/gmock_main.pc.in index f2dfe69e..66ffea7f 100644 --- a/googlemock/cmake/gmock_main.pc.in +++ b/googlemock/cmake/gmock_main.pc.in @@ -5,6 +5,6 @@ Name: gmock_main  Description: GoogleMock (with main() function)  Version: @PROJECT_VERSION@  URL: https://github.com/google/googletest -Requires: gmock +Requires: gmock = @PROJECT_VERSION@  Libs: -L${libdir} -lgmock_main @CMAKE_THREAD_LIBS_INIT@  Cflags: -I${includedir} @GTEST_HAS_PTHREAD_MACRO@ diff --git a/googlemock/docs/cook_book.md b/googlemock/docs/cook_book.md index 51eb94a9..4dbfbe09 100644 --- a/googlemock/docs/cook_book.md +++ b/googlemock/docs/cook_book.md @@ -1712,8 +1712,8 @@ brittle tests. For example, we may care about `A` occurring before both `B` and  the test should reflect our real intent, instead of being overly constraining.  gMock allows you to impose an arbitrary DAG (directed acyclic graph) on the -calls. One way to express the DAG is to use the [After](#AfterClause) clause of -`EXPECT_CALL`. +calls. One way to express the DAG is to use the +[After](cheat_sheet.md#AfterClause) clause of `EXPECT_CALL`.  Another way is via the `InSequence()` clause (not the same as the `InSequence`  class), which we borrowed from jMock 2. It's less flexible than `After()`, but diff --git a/googletest/cmake/gtest_main.pc.in b/googletest/cmake/gtest_main.pc.in index 1e01bd19..38c88c54 100644 --- a/googletest/cmake/gtest_main.pc.in +++ b/googletest/cmake/gtest_main.pc.in @@ -5,6 +5,6 @@ Name: gtest_main  Description: GoogleTest (with main() function)  Version: @PROJECT_VERSION@  URL: https://github.com/google/googletest -Requires: gtest +Requires: gtest = @PROJECT_VERSION@  Libs: -L${libdir} -lgtest_main @CMAKE_THREAD_LIBS_INIT@  Cflags: -I${includedir} @GTEST_HAS_PTHREAD_MACRO@ diff --git a/googletest/src/gtest-port.cc b/googletest/src/gtest-port.cc index a05c50a3..c1802337 100644 --- a/googletest/src/gtest-port.cc +++ b/googletest/src/gtest-port.cc @@ -208,7 +208,7 @@ size_t GetThreadCount() {    // exclude empty members    int nthreads = 0; -  for (int i = 0; i < size / mib[4]; i++) { +  for (size_t i = 0; i < size / mib[4]; i++) {      if (info[i].p_tid != -1)        nthreads++;    } diff --git a/googletest/test/googletest-death-test_ex_test.cc b/googletest/test/googletest-death-test_ex_test.cc index 7ea5b946..7219680d 100644 --- a/googletest/test/googletest-death-test_ex_test.cc +++ b/googletest/test/googletest-death-test_ex_test.cc @@ -59,7 +59,7 @@ TEST(CxxExceptionDeathTest, ExceptionIsFailure) {  class TestException : public std::exception {   public: -  const char* what() const throw() override { return "exceptional message"; } +  const char* what() const noexcept override { return "exceptional message"; }  };  TEST(CxxExceptionDeathTest, PrintsMessageForStdExceptions) { diff --git a/googletest/test/gtest-unittest-api_test.cc b/googletest/test/gtest-unittest-api_test.cc index 7d2d8cc9..25a8afb2 100644 --- a/googletest/test/gtest-unittest-api_test.cc +++ b/googletest/test/gtest-unittest-api_test.cc @@ -55,8 +55,8 @@ class UnitTestHelper {    // name.  The caller is responsible for deleting the array.    static TestSuite const** GetSortedTestSuites() {      UnitTest& unit_test = *UnitTest::GetInstance(); -    auto const** const test_suites = -        new const TestSuite*[unit_test.total_test_suite_count()]; +    auto const** const test_suites = new const TestSuite*[static_cast<size_t>( +      unit_test.total_test_suite_count())];      for (int i = 0; i < unit_test.total_test_suite_count(); ++i)        test_suites[i] = unit_test.GetTestSuite(i); @@ -83,8 +83,8 @@ class UnitTestHelper {    // sorted by the test name.  The caller is responsible for deleting the    // array.    static TestInfo const** GetSortedTests(const TestSuite* test_suite) { -    TestInfo const** const tests = -        new const TestInfo*[test_suite->total_test_count()]; +    TestInfo const** const tests = new const TestInfo*[static_cast<size_t>( +      test_suite->total_test_count())];      for (int i = 0; i < test_suite->total_test_count(); ++i)        tests[i] = test_suite->GetTestInfo(i); | 
