From 4c57b3fbdf2706a9441680cdae652c959b40dffe Mon Sep 17 00:00:00 2001 From: Andrew Cooper Date: Fri, 13 Sep 2013 14:30:02 +0200 Subject: sched/credit: Remove redundant assignments from alloc_* functions Noticed because Coverity was complaining at the atomic_set(), but because of the use of xzalloc(), these assignments of 0 are completely redundent. Signed-off-by: Andrew Cooper Acked-by: George Dunlap --- xen/common/sched_credit.c | 4 ---- 1 file changed, 4 deletions(-) (limited to 'xen/common') diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c index 0b816629e6..dbe6de666b 100644 --- a/xen/common/sched_credit.c +++ b/xen/common/sched_credit.c @@ -858,8 +858,6 @@ csched_alloc_vdata(const struct scheduler *ops, struct vcpu *vc, void *dd) INIT_LIST_HEAD(&svc->active_vcpu_elem); svc->sdom = dd; svc->vcpu = vc; - atomic_set(&svc->credit, 0); - svc->flags = 0U; svc->pri = is_idle_domain(vc->domain) ? CSCHED_PRI_IDLE : CSCHED_PRI_TS_UNDER; SCHED_VCPU_STATS_RESET(svc); @@ -1081,11 +1079,9 @@ csched_alloc_domdata(const struct scheduler *ops, struct domain *dom) /* Initialize credit and weight */ INIT_LIST_HEAD(&sdom->active_vcpu); - sdom->active_vcpu_count = 0; INIT_LIST_HEAD(&sdom->active_sdom_elem); sdom->dom = dom; sdom->weight = CSCHED_DEFAULT_WEIGHT; - sdom->cap = 0U; return (void *)sdom; } -- cgit v1.2.3