From 0fbf3208d9c1a568aeeb61d9f4fbca03b1cfa1f8 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Mon, 9 Sep 2013 14:34:12 +0200 Subject: xmalloc: make whole pages xfree() clear the order field (ab)used by xmalloc() Not doing this was found to cause problems with sequences of allocation (multi-page), freeing, and then again allocation of the same page upon boot when interrupts are still disabled (causing the owner field to be non-zero, thus making the allocator attempt a TLB flush and, in its processing, triggering an assertion). Reported-by: Tomasz Wroblewski Signed-off-by: Jan Beulich Tested-by: Tomasz Wroblewski Acked-by: Keir Fraser --- xen/common/xmalloc_tlsf.c | 1 + 1 file changed, 1 insertion(+) (limited to 'xen/common') diff --git a/xen/common/xmalloc_tlsf.c b/xen/common/xmalloc_tlsf.c index f19fb85f1f..d3bdfa7d57 100644 --- a/xen/common/xmalloc_tlsf.c +++ b/xen/common/xmalloc_tlsf.c @@ -629,6 +629,7 @@ void xfree(void *p) unsigned int i, order = get_order_from_pages(size); BUG_ON((unsigned long)p & ((PAGE_SIZE << order) - 1)); + PFN_ORDER(virt_to_page(p)) = 0; for ( i = 0; ; ++i ) { if ( !(size & (1 << i)) ) -- cgit v1.2.3