From 0a706be1ab4651a1513bd929d4e2b2054a9c823c Mon Sep 17 00:00:00 2001 From: "kfraser@localhost.localdomain" Date: Tue, 19 Sep 2006 11:08:11 +0100 Subject: [XENMON] Add argument check of "--ms_per_sample" option. If a value of "--ms_per_sample" option is larger than a value of "--time" option, xenmon may generate no log file. So, too large "--ms_per_sample" should be treated as an error. e.g. % xenmon.py --ms_per_sample=2000 -t 1 -n usage: xenmon.py [options] xenmon.py: error: option --ms_per_sample: too large (> 1000 ms) # Notice that a unit of "--time" is a second. Signed-off-by: KUWAMURA Shin'ya --- tools/xenmon/xenmon.py | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'tools/xenmon') diff --git a/tools/xenmon/xenmon.py b/tools/xenmon/xenmon.py index 402b6b4e18..e6b8ce9e24 100644 --- a/tools/xenmon/xenmon.py +++ b/tools/xenmon/xenmon.py @@ -675,6 +675,11 @@ def main(): if options.mspersample < 0: parser.error("option --ms_per_sample: invalid negative value: '%d'" % options.mspersample) + # If --ms_per_sample= is too large, no data may be logged. + if not options.live and options.duration != 0 and \ + options.mspersample > options.duration * 1000: + parser.error("option --ms_per_sample: too large (> %d ms)" % + (options.duration * 1000)) start_xenbaked() if options.live: -- cgit v1.2.3