From 6a994f3e89a554e38ec549292448467660f90d02 Mon Sep 17 00:00:00 2001 From: Olaf Hering Date: Thu, 2 Aug 2012 10:46:02 +0100 Subject: pygrub: add quoting to install receipe The changeset 25694:e20085770cb5 causes a syntax error if readline returns nothing due to non-existant path: [ 148s] set -e; if [ `readlink -f /home/abuild/rpmbuild/BUILD/xen-4.2.25700/non-dbg/dist/install//usr/bin` != \ [ 148s] `readlink -f /usr/lib64/xen/bin` ]; then \ [ 148s] ln -sf /usr/lib64/xen/bin/pygrub /home/abuild/rpmbuild/BUILD/xen-4.2.25700/non-dbg/dist/install//usr/bin; \ [ 148s] fi [ 148s] /bin/sh: line 0: [: /home/abuild/rpmbuild/BUILD/xen-4.2.25700/non-dbg/dist/install/usr/bin: unary operator expected Add quoting to fix the error. Signed-off-by: Olaf Hering Acked-by: Ian Campbell Committed-by: Ian Campbell --- tools/pygrub/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'tools/pygrub') diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile index 8c99e11b68..039f7f7e4a 100644 --- a/tools/pygrub/Makefile +++ b/tools/pygrub/Makefile @@ -14,8 +14,8 @@ install: all $(PYTHON_PREFIX_ARG) --root="$(DESTDIR)" \ --install-scripts=$(PRIVATE_BINDIR) --force $(INSTALL_DIR) $(DESTDIR)/var/run/xend/boot - set -e; if [ `readlink -f $(DESTDIR)/$(BINDIR)` != \ - `readlink -f $(PRIVATE_BINDIR)` ]; then \ + set -e; if [ "`readlink -f $(DESTDIR)/$(BINDIR)`" != \ + "`readlink -f $(PRIVATE_BINDIR)`" ]; then \ ln -sf $(PRIVATE_BINDIR)/pygrub $(DESTDIR)/$(BINDIR); \ fi -- cgit v1.2.3