From 456639bbab924d8641dbca4468ac8998428c3e92 Mon Sep 17 00:00:00 2001 From: Roger Pau Monne Date: Fri, 11 May 2012 18:59:03 +0100 Subject: libxl: set guest_domid even if libxl__domain_make fails This is needed in order to perform the domain destruction if libxl__domain_make fails. Also move doc comment about error behaviour of libxl__domain_make from implementation to declaration. Signed-off-by: Roger Pau Monne Signed-off-by: Ian Jackson Committed-by: Ian Jackson --- tools/libxl/libxl_create.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'tools/libxl/libxl_create.c') diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c index 9ce107a689..50755379fa 100644 --- a/tools/libxl/libxl_create.c +++ b/tools/libxl/libxl_create.c @@ -396,8 +396,6 @@ out: int libxl__domain_make(libxl__gc *gc, libxl_domain_create_info *info, uint32_t *domid) - /* on entry, libxl_domid_valid_guest(domid) must be false; - * on exit (even error exit), domid may be valid and refer to a domain */ { libxl_ctx *ctx = libxl__gc_owner(gc); int flags, ret, rc; @@ -600,6 +598,7 @@ static void initiate_domain_create(libxl__egc *egc, ret = libxl__domain_make(gc, &d_config->c_info, &domid); if (ret) { LIBXL__LOG(ctx, LIBXL__LOG_ERROR, "cannot make domain: %d", ret); + dcs->guest_domid = domid; ret = ERROR_FAIL; goto error_out; } -- cgit v1.2.3