From 5622adc37204b9408d0ee1de57ad16236052f2fd Mon Sep 17 00:00:00 2001 From: Olaf Hering Date: Thu, 18 Oct 2012 09:35:01 +0100 Subject: hotplug/Linux: close lockfd after lock attempt When a HVM guest is shutdown some of the 'remove' events can not claim the lock for some reason. Instead they try to grab the lock in a busy loop, until udev reaps the xen-hotplug-cleanup helper. After analyzing the resulting logfile its not obvious what the cause is. The only explanation is that bash (?) gets confused if the same lockfd is opened again and again. Closing it in each iteration seem to fix the issue. This was observed with sles11sp2 (bash 3.2) and 4.2 xend. Signed-off-by: Olaf Hering Acked-by: Ian Campbell [ ijc -- added the comment ] Committed-by: Ian Campbell --- tools/hotplug/Linux/locking.sh | 3 +++ 1 file changed, 3 insertions(+) (limited to 'tools/hotplug') diff --git a/tools/hotplug/Linux/locking.sh b/tools/hotplug/Linux/locking.sh index 0e2a531cb3..e34f155438 100644 --- a/tools/hotplug/Linux/locking.sh +++ b/tools/hotplug/Linux/locking.sh @@ -59,6 +59,9 @@ claim_lock() print "y\n" if $fd_inum eq $file_inum; ' "$_lockfile" ) if [ x$rightfile = xy ]; then break; fi + # Some versions of bash appear to be buggy if the same + # $_lockfile is opened repeatedly. Close the current fd here. + eval "exec $_lockfd<&-" done } -- cgit v1.2.3