From 27d3eb3d9953399d78b648efac6565e92613cae1 Mon Sep 17 00:00:00 2001 From: Gianni Tedesco Date: Tue, 3 Aug 2010 17:34:08 +0100 Subject: libblktapctl: fix use-after-free bug This has not caused crashes because generally use after free is OK provided nothing else is going on. However the patch makes things correct. It also allows us to use heap poisoning feature of valgrind on tools linking to libblktapctl. Signed-off-by: Gianni Tedesco Signed-off-by: Stefano Stabellini --- tools/blktap2/control/tap-ctl-list.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'tools/blktap2') diff --git a/tools/blktap2/control/tap-ctl-list.c b/tools/blktap2/control/tap-ctl-list.c index 55de3e772d..1497270874 100644 --- a/tools/blktap2/control/tap-ctl-list.c +++ b/tools/blktap2/control/tap-ctl-list.c @@ -385,9 +385,9 @@ _tap_ctl_free_tapdisks(struct tapdisk *tapv, int n_taps) struct tapdisk *tap; for (tap = tapv; tap < &tapv[n_taps]; ++tap) { - struct tapdisk_list *tl; + struct tapdisk_list *tl, *next; - list_for_each_entry(tl, &tap->list, entry) { + list_for_each_entry_safe(tl, next, &tap->list, entry) { free(tl->params); free(tl); } -- cgit v1.2.3