From 1676d94292f97fa86fcafa6348ac57d12c270054 Mon Sep 17 00:00:00 2001 From: John Weekes Date: Tue, 11 Jan 2011 16:42:41 +0000 Subject: stubdom: Fix stubdom-dm using "grep" improperly stubdom-dm uses "grep" on "xm list" output to determine whether it is already running. The existing behavior is to use "grep $domname-dm" but this will result in a false-positive in the case of another domU running whose name ends with the full new name; for instance, if "abctest-dm" is running, a new "test-dm" will spin forever, waiting for it the end. Any easy fix is to have it use "grep -w" instead of "grep", searching for the whole word only. It also might be worth considering a switch to "xl list" from "xm list", here and in other places. Signed-off-by: John Weekes Committed-by: Ian Jackson --- stubdom/stubdom-dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'stubdom') diff --git a/stubdom/stubdom-dm b/stubdom/stubdom-dm index c85fa53635..05d07ac0d1 100644 --- a/stubdom/stubdom-dm +++ b/stubdom/stubdom-dm @@ -91,7 +91,7 @@ trap term SIGHUP ############ # stubdomain # Wait for any previous stubdom to terminate -while xm list | grep $domname-dm +while xm list | grep -w $domname-dm do sleep 1 done -- cgit v1.2.3