From 83789acac046c93170f00c1c8fc2c1452ff315a1 Mon Sep 17 00:00:00 2001 From: Matt Wilson Date: Fri, 6 Sep 2013 12:52:05 -0700 Subject: minios: clean up allocation of char arrays used for xenbus paths This patch cleans up instances of char array allocation where string lengths were manually counted to use strlen() instead. There are no functional changes in this patch. Signed-off-by: Matt Wilson Cc: Stefano Stabellini Acked-By: Samuel Thibault --- extras/mini-os/blkfront.c | 6 +++--- extras/mini-os/console/xenbus.c | 4 ++-- extras/mini-os/fbfront.c | 10 +++++----- extras/mini-os/netfront.c | 4 ++-- extras/mini-os/pcifront.c | 8 ++++---- 5 files changed, 16 insertions(+), 16 deletions(-) (limited to 'extras') diff --git a/extras/mini-os/blkfront.c b/extras/mini-os/blkfront.c index 70976f58d0..73837f65b7 100644 --- a/extras/mini-os/blkfront.c +++ b/extras/mini-os/blkfront.c @@ -99,7 +99,7 @@ struct blkfront_dev *init_blkfront(char *_nodename, struct blkfront_info *info) struct blkfront_dev *dev; - char path[strlen(nodename) + 1 + 10 + 1]; + char path[strlen(nodename) + strlen("/backend-id") + 1]; printk("******************* BLKFRONT for %s **********\n\n\n", nodename); @@ -189,7 +189,7 @@ done: { XenbusState state; - char path[strlen(dev->backend) + 1 + 19 + 1]; + char path[strlen(dev->backend) + strlen("/feature-flush-cache") + 1]; snprintf(path, sizeof(path), "%s/mode", dev->backend); msg = xenbus_read(XBT_NIL, path, &c); if (msg) { @@ -253,7 +253,7 @@ void shutdown_blkfront(struct blkfront_dev *dev) char* err = NULL; XenbusState state; - char path[strlen(dev->backend) + 1 + 5 + 1]; + char path[strlen(dev->backend) + strlen("/state") + 1]; char nodename[strlen(dev->nodename) + strlen("/event-channel") + 1]; blkfront_sync(dev); diff --git a/extras/mini-os/console/xenbus.c b/extras/mini-os/console/xenbus.c index 1ecfcc542e..23d4d32aea 100644 --- a/extras/mini-os/console/xenbus.c +++ b/extras/mini-os/console/xenbus.c @@ -18,8 +18,8 @@ void free_consfront(struct consfront_dev *dev) char* err = NULL; XenbusState state; - char path[strlen(dev->backend) + 1 + 5 + 1]; - char nodename[strlen(dev->nodename) + 1 + 5 + 1]; + char path[strlen(dev->backend) + strlen("/state") + 1]; + char nodename[strlen(dev->nodename) + strlen("/state") + 1]; snprintf(path, sizeof(path), "%s/state", dev->backend); snprintf(nodename, sizeof(nodename), "%s/state", dev->nodename); diff --git a/extras/mini-os/fbfront.c b/extras/mini-os/fbfront.c index 6eddb3cca3..9148496953 100644 --- a/extras/mini-os/fbfront.c +++ b/extras/mini-os/fbfront.c @@ -75,7 +75,7 @@ struct kbdfront_dev *init_kbdfront(char *_nodename, int abs_pointer) char* nodename = _nodename ? _nodename : "device/vkbd/0"; struct kbdfront_dev *dev; - char path[strlen(nodename) + 1 + 10 + 1]; + char path[strlen(nodename) + strlen("/backend-id") + 1]; printk("******************* KBDFRONT for %s **********\n\n\n", nodename); @@ -239,7 +239,7 @@ void shutdown_kbdfront(struct kbdfront_dev *dev) char* err = NULL; XenbusState state; - char path[strlen(dev->backend) + 1 + 5 + 1]; + char path[strlen(dev->backend) + strlen("/state") + 1]; char nodename[strlen(dev->nodename) + strlen("/request-abs-pointer") + 1]; printk("close kbd: backend at %s\n",dev->backend); @@ -413,7 +413,7 @@ struct fbfront_dev *init_fbfront(char *_nodename, unsigned long *mfns, int width unsigned long mapped; char* nodename = _nodename ? _nodename : "device/vfb/0"; - char path[strlen(nodename) + 1 + 10 + 1]; + char path[strlen(nodename) + strlen("/backend-id") + 1]; printk("******************* FBFRONT for %s **********\n\n\n", nodename); @@ -520,7 +520,7 @@ done: { XenbusState state; - char path[strlen(dev->backend) + 1 + 14 + 1]; + char path[strlen(dev->backend) + strlen("/request-update") + 1]; char frontpath[strlen(nodename) + strlen("/state") + 1]; snprintf(path, sizeof(path), "%s/state", dev->backend); @@ -631,7 +631,7 @@ void shutdown_fbfront(struct fbfront_dev *dev) char* err = NULL; XenbusState state; - char path[strlen(dev->backend) + 1 + 5 + 1]; + char path[strlen(dev->backend) + strlen("/state") + 1]; char nodename[strlen(dev->nodename) + strlen("/feature-update") + 1]; printk("close fb: backend at %s\n",dev->backend); diff --git a/extras/mini-os/netfront.c b/extras/mini-os/netfront.c index ddf56ea7a1..7947fc256b 100644 --- a/extras/mini-os/netfront.c +++ b/extras/mini-os/netfront.c @@ -441,7 +441,7 @@ done: { XenbusState state; - char path[strlen(dev->backend) + 1 + 5 + 1]; + char path[strlen(dev->backend) + strlen("/state") + 1]; snprintf(path, sizeof(path), "%s/state", dev->backend); xenbus_watch_path_token(XBT_NIL, path, path, &dev->events); @@ -507,7 +507,7 @@ void shutdown_netfront(struct netfront_dev *dev) char* err = NULL; XenbusState state; - char path[strlen(dev->backend) + 1 + 5 + 1]; + char path[strlen(dev->backend) + strlen("/state") + 1]; char nodename[strlen(dev->nodename) + strlen("/request-rx-copy") + 1]; printk("close network: backend at %s\n",dev->backend); diff --git a/extras/mini-os/pcifront.c b/extras/mini-os/pcifront.c index f9ae768170..e6a5f4e7bf 100644 --- a/extras/mini-os/pcifront.c +++ b/extras/mini-os/pcifront.c @@ -149,7 +149,7 @@ struct pcifront_dev *init_pcifront(char *_nodename) struct pcifront_dev *dev; - char path[strlen(nodename) + 1 + 10 + 1]; + char path[strlen(nodename) + strlen("/backend-id") + 1]; if (!_nodename && pcidev) return pcidev; @@ -237,8 +237,8 @@ done: printk("backend at %s\n", dev->backend); { - char path[strlen(dev->backend) + 1 + 5 + 1]; - char frontpath[strlen(nodename) + 1 + 5 + 1]; + char path[strlen(dev->backend) + strlen("/state") + 1]; + char frontpath[strlen(nodename) + strlen("/state") + 1]; XenbusState state; snprintf(path, sizeof(path), "%s/state", dev->backend); @@ -322,7 +322,7 @@ void shutdown_pcifront(struct pcifront_dev *dev) char* err = NULL; XenbusState state; - char path[strlen(dev->backend) + 1 + 5 + 1]; + char path[strlen(dev->backend) + strlen("/state") + 1]; char nodename[strlen(dev->nodename) + strlen("/event-channel") + 1]; printk("close pci: backend at %s\n",dev->backend); -- cgit v1.2.3