From 72b9c3e88c1cd205b39b178ce5e684868a1117c2 Mon Sep 17 00:00:00 2001 From: Matthew Daley Date: Wed, 11 Sep 2013 02:34:19 +1200 Subject: mini-os: fix use-after-free in xs_daemon_close event iteration We need to get the next pointer before the freeing of the event. Coverity-ID: 1056173 Signed-off-by: Matthew Daley Acked-By: Samuel Thibault --- extras/mini-os/lib/xs.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'extras') diff --git a/extras/mini-os/lib/xs.c b/extras/mini-os/lib/xs.c index a2a122098c..c603d178bf 100644 --- a/extras/mini-os/lib/xs.c +++ b/extras/mini-os/lib/xs.c @@ -29,9 +29,12 @@ struct xs_handle *xs_daemon_open() void xs_daemon_close(struct xs_handle *h) { int fd = _xs_fileno(h); - struct xenbus_event *event; - for (event = files[fd].xenbus.events; event; event = event->next) + struct xenbus_event *event, *next; + for (event = files[fd].xenbus.events; event; event = next) + { + next = event->next; free(event); + } files[fd].type = FTYPE_NONE; } -- cgit v1.2.3