From f220279c14f5bcbaeb520c4f2498f25d795213e6 Mon Sep 17 00:00:00 2001 From: Matthew Daley Date: Wed, 18 Sep 2013 15:37:56 +1200 Subject: xenstore: check socket path length before copying it Coverity-ID: 1055997 Signed-off-by: Matthew Daley Acked-by: Ian Campbell --- tools/xenstore/xs.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/xenstore/xs.c b/tools/xenstore/xs.c index 86ef6c7f3e..b1e6820cf4 100644 --- a/tools/xenstore/xs.c +++ b/tools/xenstore/xs.c @@ -196,6 +196,10 @@ static int get_socket(const char *connect_to) goto error; addr.sun_family = AF_UNIX; + if(strlen(connect_to) >= sizeof(addr.sun_path)) { + errno = EINVAL; + goto error; + } strcpy(addr.sun_path, connect_to); if (connect(sock, (struct sockaddr *)&addr, sizeof(addr)) != 0) -- cgit v1.2.3