From eba971d94289d91e4a3959d2c083a59deb100568 Mon Sep 17 00:00:00 2001 From: Matthew Daley Date: Tue, 10 Sep 2013 22:18:46 +1200 Subject: libxl: fix out-of-memory error handling in libxl_list_cpupool ...otherwise it will return freed memory. All the current users of this function check already for a NULL return, so use that. Coverity-ID: 1056194 This is CVE-2013-4371 / XSA-70 Signed-off-by: Matthew Daley Acked-by: Ian Campbell (cherry picked from commit 4c37ed562224295c0f8b00211287d57cae629782) (cherry picked from commit 2350e70ee06c903a927340f7a0bf9ca25acce3f3) --- tools/libxl/libxl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 32d788abdb..e8d798e247 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -648,6 +648,7 @@ libxl_cpupoolinfo * libxl_list_cpupool(libxl_ctx *ctx, int *nb_pool_out) if (!tmp) { LIBXL__LOG_ERRNO(ctx, LIBXL__LOG_ERROR, "allocating cpupool info"); libxl_cpupoolinfo_list_free(ptr, i); + ptr = NULL; goto out; } ptr = tmp; -- cgit v1.2.3