From d9b46e5c84fdd38b4df766148bdf6582b4a04746 Mon Sep 17 00:00:00 2001 From: George Dunlap Date: Mon, 23 Sep 2013 16:27:08 +0200 Subject: x86/HVM: fix failure path in hvm_vcpu_initialise It looks like one of the failure cases in hvm_vcpu_initialise jumps to the wrong label; this could lead to slow leaks if something isn't cleaned up properly. I will probably change these labels in a future patch, but I figured it was better to have this fix separately. This is also a candidate for backport. Signed-off-by: George Dunlap Signed-off-by: Mukesh Rathor master commit: 925fbcb7fdd6238f26b1576dc1f3e297f1f24f1e master date: 2013-09-18 14:45:24 +0200 --- xen/arch/x86/hvm/hvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 26a3e9f848..a2fb715116 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -1125,7 +1125,7 @@ int hvm_vcpu_initialise(struct vcpu *v) /* Create bufioreq event channel. */ rc = alloc_unbound_xen_event_channel(v, dm_domid, NULL); if ( rc < 0 ) - goto fail2; + goto fail4; d->arch.hvm_domain.params[HVM_PARAM_BUFIOREQ_EVTCHN] = rc; } -- cgit v1.2.3