From 6311dc03dac464cba03979b6b4eba804b0bb0613 Mon Sep 17 00:00:00 2001 From: "kfraser@localhost.localdomain" Date: Tue, 17 Oct 2006 15:57:05 +0100 Subject: Clean up duplication of 'install' macros in the Makefiles. Signed-off-by: John Levon --- docs/Makefile | 5 +++-- tools/blktap/drivers/Makefile | 6 ++---- tools/blktap/lib/Makefile | 4 ---- tools/console/Makefile | 4 ---- tools/examples/Makefile | 5 ----- tools/firmware/Makefile | 6 +++--- tools/firmware/acpi/Makefile | 2 +- tools/ioemu/Makefile.target | 6 +++--- tools/libxc/Makefile | 10 ++-------- tools/misc/Makefile | 4 ---- tools/misc/lomount/Makefile | 5 ----- tools/misc/mbootpack/Makefile | 4 ---- tools/misc/miniterm/Makefile | 4 ---- tools/vnet/doc/Makefile | 5 ++--- tools/vnet/examples/Makefile | 6 ++---- tools/vnet/libxutil/Makefile | 5 ----- tools/vnet/scripts/Makefile | 6 ++---- tools/vnet/vnetd/Makefile | 2 +- tools/vtpm/Rules.mk | 5 ----- tools/vtpm_manager/Rules.mk | 5 ----- tools/xcutils/Makefile | 4 ---- tools/xenmon/Makefile | 9 ++------- tools/xenstat/libxenstat/Makefile | 4 ---- tools/xenstat/xentop/Makefile | 4 ---- tools/xenstore/Makefile | 5 ----- tools/xentrace/Makefile | 5 ----- xen/Rules.mk | 4 ---- 27 files changed, 23 insertions(+), 111 deletions(-) diff --git a/docs/Makefile b/docs/Makefile index 59e9fa69d7..0432855384 100644 --- a/docs/Makefile +++ b/docs/Makefile @@ -1,8 +1,9 @@ #!/usr/bin/make -f +XEN_ROOT=.. +include $(XEN_ROOT)/Config.mk + VERSION = xen-unstable -INSTALL = install -INSTALL_DIR = $(INSTALL) -d -m0755 PS2PDF := ps2pdf DVIPS := dvips diff --git a/tools/blktap/drivers/Makefile b/tools/blktap/drivers/Makefile index 80b0ad1dbe..e1324063e6 100644 --- a/tools/blktap/drivers/Makefile +++ b/tools/blktap/drivers/Makefile @@ -3,11 +3,9 @@ include $(XEN_ROOT)/tools/Rules.mk INCLUDES += -I.. -I../lib -INSTALL = install -INSTALL_PROG = $(INSTALL) -m0755 IBIN = blktapctrl tapdisk QCOW_UTIL = img2qcow qcow2raw qcow-create -INSTALL_DIR = /usr/sbin +INST_DIR = /usr/sbin LIBAIO_DIR = ../../libaio/src CFLAGS += -Werror @@ -58,7 +56,7 @@ img2qcow qcow2raw qcow-create: %: $(BLK-OBJS) $(CC) $(CFLAGS) -o $* $(BLK-OBJS) $*.c $(AIOLIBS) $(LIBS) install: all - $(INSTALL_PROG) $(IBIN) $(QCOW_UTIL) $(DESTDIR)$(INSTALL_DIR) + $(INSTALL_PROG) $(IBIN) $(QCOW_UTIL) $(DESTDIR)$(INST_DIR) clean: rm -rf *.o *~ $(DEPS) xen TAGS $(IBIN) $(LIB) $(QCOW_UTIL) diff --git a/tools/blktap/lib/Makefile b/tools/blktap/lib/Makefile index 38f8ac686c..cde602bd0b 100644 --- a/tools/blktap/lib/Makefile +++ b/tools/blktap/lib/Makefile @@ -7,10 +7,6 @@ SONAME = libblktap.so.$(MAJOR) BLKTAP_INSTALL_DIR = /usr/sbin -INSTALL = install -INSTALL_PROG = $(INSTALL) -m0755 -INSTALL_DIR = $(INSTALL) -d -m0755 - INCLUDES += -I. -I.. -I $(XEN_LIBXC) -I $(XEN_XENSTORE) LIBS := -lz diff --git a/tools/console/Makefile b/tools/console/Makefile index cbef956c5f..2d4486c87f 100644 --- a/tools/console/Makefile +++ b/tools/console/Makefile @@ -5,10 +5,6 @@ include $(XEN_ROOT)/tools/Rules.mk DAEMON_INSTALL_DIR = /usr/sbin CLIENT_INSTALL_DIR = /usr/$(LIBDIR)/xen/bin -INSTALL = install -INSTALL_PROG = $(INSTALL) -m0755 -INSTALL_DIR = $(INSTALL) -d -m0755 - CFLAGS += -Werror -g CFLAGS += -I $(XEN_LIBXC) diff --git a/tools/examples/Makefile b/tools/examples/Makefile index cc5525c2a3..14f34135c8 100644 --- a/tools/examples/Makefile +++ b/tools/examples/Makefile @@ -1,11 +1,6 @@ XEN_ROOT = ../../ include $(XEN_ROOT)/tools/Rules.mk -INSTALL = install -INSTALL_DIR = $(INSTALL) -d -m0755 -INSTALL_PROG = $(INSTALL) -m0755 -INSTALL_DATA = $(INSTALL) -m0644 - # Init scripts. XEND_INITD = init.d/xend XENDOMAINS_INITD = init.d/xendomains diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile index 63ccb7b17e..a024e1249e 100644 --- a/tools/firmware/Makefile +++ b/tools/firmware/Makefile @@ -4,7 +4,7 @@ include $(XEN_ROOT)/tools/Rules.mk # hvmloader is a 32-bit protected mode binary. # It belongs in /usr/lib, not /usr/lib64. TARGET := hvmloader/hvmloader -INSTALL_DIR := $(DESTDIR)/usr/lib/xen/boot +INST_DIR := $(DESTDIR)/usr/lib/xen/boot SUBDIRS := SUBDIRS += rombios @@ -29,8 +29,8 @@ all: .PHONY: install install: all - [ -d $(INSTALL_DIR) ] || install -d -m0755 $(INSTALL_DIR) - [ ! -e $(TARGET) ] || install -m0644 $(TARGET) $(INSTALL_DIR) + [ -d $(INST_DIR) ] || $(INSTALL_DIR) $(INST_DIR) + [ ! -e $(TARGET) ] || $(INSTALL_DATA) $(TARGET) $(INST_DIR) .PHONY: clean clean: diff --git a/tools/firmware/acpi/Makefile b/tools/firmware/acpi/Makefile index b87cb79a33..3b4bb99b49 100644 --- a/tools/firmware/acpi/Makefile +++ b/tools/firmware/acpi/Makefile @@ -53,7 +53,7 @@ iasl: wget $(IASL_URL) tar xzf $(IASL_VER).tar.gz make -C $(IASL_VER)/compiler - install $(IASL_VER)/compiler/iasl /usr/bin/iasl + $(INSTALL_PROG) $(IASL_VER)/compiler/iasl /usr/bin/iasl $(ACPI_GEN):$(C_SRC) $(H_SRC) acpi_dsdt.c $(HOSTCC) -o $(ACPI_GEN) $(HOSTCFLAGS) $(shell ls *.c) diff --git a/tools/ioemu/Makefile.target b/tools/ioemu/Makefile.target index c495abbf59..7af1fdd646 100644 --- a/tools/ioemu/Makefile.target +++ b/tools/ioemu/Makefile.target @@ -555,10 +555,10 @@ distclean: clean install: all mkdir -p "$(DESTDIR)$(bindir)" "$(DESTDIR)$(configdir)" ifneq ($(PROGS),) - $(INSTALL) -m 755 -s $(PROGS) "$(DESTDIR)$(bindir)" + $(INSTALL_PROG) $(PROGS) "$(DESTDIR)$(bindir)" endif - install -m 755 $(TARGET_PATH)/qemu-dm.debug "$(DESTDIR)$(bindir)" - install -m 755 $(TARGET_PATH)/qemu-ifup "$(DESTDIR)$(configdir)" + $(INSTALL_PROG) $(TARGET_PATH)/qemu-dm.debug "$(DESTDIR)$(bindir)" + $(INSTALL_PROG) $(TARGET_PATH)/qemu-ifup "$(DESTDIR)$(configdir)" ifneq ($(wildcard .depend),) include .depend diff --git a/tools/libxc/Makefile b/tools/libxc/Makefile index caec7ec38a..f4a5f1c2f6 100644 --- a/tools/libxc/Makefile +++ b/tools/libxc/Makefile @@ -1,15 +1,9 @@ - -INSTALL = install -INSTALL_PROG = $(INSTALL) -m0755 -INSTALL_DATA = $(INSTALL) -m0644 -INSTALL_DIR = $(INSTALL) -d -m0755 +XEN_ROOT = ../.. +include $(XEN_ROOT)/tools/Rules.mk MAJOR = 3.0 MINOR = 0 -XEN_ROOT = ../.. -include $(XEN_ROOT)/tools/Rules.mk - CTRL_SRCS-y := CTRL_SRCS-y += xc_core.c CTRL_SRCS-y += xc_domain.c diff --git a/tools/misc/Makefile b/tools/misc/Makefile index eb6529f12d..8d5c349efb 100644 --- a/tools/misc/Makefile +++ b/tools/misc/Makefile @@ -1,7 +1,3 @@ -INSTALL = install -INSTALL_PROG = $(INSTALL) -m0755 -INSTALL_DIR = $(INSTALL) -d -m0755 - XEN_ROOT=../.. include $(XEN_ROOT)/tools/Rules.mk diff --git a/tools/misc/lomount/Makefile b/tools/misc/lomount/Makefile index 0ed470b1d3..04c928d66f 100644 --- a/tools/misc/lomount/Makefile +++ b/tools/misc/lomount/Makefile @@ -1,8 +1,3 @@ -INSTALL = install -INSTALL_PROG = $(INSTALL) -m0755 -INSTALL_DIR = $(INSTALL) -d -m0755 -INSTALL_DATA = $(INSTALL) -m0644 - XEN_ROOT=../../.. include $(XEN_ROOT)/tools/Rules.mk diff --git a/tools/misc/mbootpack/Makefile b/tools/misc/mbootpack/Makefile index d4ac73d954..872eb3ee95 100644 --- a/tools/misc/mbootpack/Makefile +++ b/tools/misc/mbootpack/Makefile @@ -1,10 +1,6 @@ # # Makefile for mbootpack # -INSTALL = install -INSTALL_PROG = $(INSTALL) -m0755 -INSTALL_DIR = $(INSTALL) -d -m0755 - XEN_ROOT=../../.. include $(XEN_ROOT)/tools/Rules.mk diff --git a/tools/misc/miniterm/Makefile b/tools/misc/miniterm/Makefile index 5b596a5f9f..1fe35f810c 100644 --- a/tools/misc/miniterm/Makefile +++ b/tools/misc/miniterm/Makefile @@ -1,10 +1,6 @@ XEN_ROOT:=../../.. include $(XEN_ROOT)/tools/Rules.mk -INSTALL = install -INSTALL_PROG = $(INSTALL) -m0755 -INSTALL_DIR = $(INSTALL) -d -m0755 - TARGET = miniterm .PHONY: all diff --git a/tools/vnet/doc/Makefile b/tools/vnet/doc/Makefile index 67f70ab68d..38accfa7f6 100644 --- a/tools/vnet/doc/Makefile +++ b/tools/vnet/doc/Makefile @@ -1,12 +1,11 @@ #!/usr/bin/make -f # -*- mode: Makefile; -*- +XEN_ROOT = ../../.. +include $(XEN_ROOT)/tools/Rules.mk VERSION = 1.0 HEADER = Vnet -INSTALL = install -INSTALL_DIR = $(INSTALL) -d -m0755 - PS2PDF := ps2pdf DVIPS := dvips LATEX := latex diff --git a/tools/vnet/examples/Makefile b/tools/vnet/examples/Makefile index ba605ca318..c3aab0c70e 100644 --- a/tools/vnet/examples/Makefile +++ b/tools/vnet/examples/Makefile @@ -1,9 +1,7 @@ # -*- mode: Makefile; -*- #============================================================================ - -INSTALL = install -INSTALL_PROG = $(INSTALL) -m0755 -INSTALL_DIR = $(INSTALL) -d -m0755 +XEN_ROOT = ../../.. +include $(XEN_ROOT)/tools/Rules.mk XEN_SCRIPT_DIR = $(DESTDIR)/etc/xen/scripts diff --git a/tools/vnet/libxutil/Makefile b/tools/vnet/libxutil/Makefile index b8661276d8..b38cf11daa 100644 --- a/tools/vnet/libxutil/Makefile +++ b/tools/vnet/libxutil/Makefile @@ -3,11 +3,6 @@ export VNET_ROOT = $(shell cd .. && pwd) include $(VNET_ROOT)/Make.env endif -INSTALL = install -INSTALL_DATA = $(INSTALL) -m0644 -INSTALL_PROG = $(INSTALL) -m0755 -INSTALL_DIR = $(INSTALL) -d -m0755 - include $(XEN_ROOT)/tools/Rules.mk LIB_SRCS := diff --git a/tools/vnet/scripts/Makefile b/tools/vnet/scripts/Makefile index 077d6b6224..24f6f35880 100644 --- a/tools/vnet/scripts/Makefile +++ b/tools/vnet/scripts/Makefile @@ -1,9 +1,7 @@ # -*- mode: Makefile; -*- #============================================================================ - -INSTALL = install -INSTALL_PROG = $(INSTALL) -m0755 -INSTALL_DIR = $(INSTALL) -d -m0755 +XEN_ROOT = ../../.. +include $(XEN_ROOT)/tools/Rules.mk SBIN_DIR = $(DESTDIR)/usr/sbin diff --git a/tools/vnet/vnetd/Makefile b/tools/vnet/vnetd/Makefile index 93e6dbce43..530284c218 100644 --- a/tools/vnet/vnetd/Makefile +++ b/tools/vnet/vnetd/Makefile @@ -110,7 +110,7 @@ vnetd: $(VNETD_OBJ) .PHONY: install install: vnetd mkdir -p $(DESTDIR)$(VNETD_INSTALL_DIR) - install -m 0755 vnetd $(DESTDIR)$(VNETD_INSTALL_DIR) + $(INSTALL_PROG) vnetd $(DESTDIR)$(VNETD_INSTALL_DIR) .PHONY: clean clean: diff --git a/tools/vtpm/Rules.mk b/tools/vtpm/Rules.mk index 9ce85dc316..8eb1a3c343 100644 --- a/tools/vtpm/Rules.mk +++ b/tools/vtpm/Rules.mk @@ -5,11 +5,6 @@ include $(XEN_ROOT)/tools/Rules.mk # Tool definitions # -# Installation program and options -INSTALL = install -INSTALL_PROG = $(INSTALL) -m0755 -INSTALL_DIR = $(INSTALL) -d -m0755 - # Xen tools installation directory TOOLS_INSTALL_DIR = $(DESTDIR)/usr/bin diff --git a/tools/vtpm_manager/Rules.mk b/tools/vtpm_manager/Rules.mk index 3435afed38..68c2a26ff7 100644 --- a/tools/vtpm_manager/Rules.mk +++ b/tools/vtpm_manager/Rules.mk @@ -5,11 +5,6 @@ include $(XEN_ROOT)/tools/Rules.mk # Tool definitions # -# Installation program and options -INSTALL = install -INSTALL_PROG = $(INSTALL) -m0755 -INSTALL_DIR = $(INSTALL) -d -m0755 - # Xen tools installation directory TOOLS_INSTALL_DIR = $(DESTDIR)/usr/bin diff --git a/tools/xcutils/Makefile b/tools/xcutils/Makefile index 24031a1688..063c636f27 100644 --- a/tools/xcutils/Makefile +++ b/tools/xcutils/Makefile @@ -8,10 +8,6 @@ # Copyright (C) 2005 by Christian Limpach # -INSTALL = install -INSTALL_PROG = $(INSTALL) -m0755 -INSTALL_DIR = $(INSTALL) -d -m0755 - XEN_ROOT = ../.. include $(XEN_ROOT)/tools/Rules.mk diff --git a/tools/xenmon/Makefile b/tools/xenmon/Makefile index 3d46dbe548..725567d619 100644 --- a/tools/xenmon/Makefile +++ b/tools/xenmon/Makefile @@ -10,16 +10,11 @@ # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -INSTALL = install -INSTALL_PROG = $(INSTALL) -m0755 -INSTALL_DIR = $(INSTALL) -d -m0755 -INSTALL_DATA = $(INSTALL) -m0644 - -sbindir=/usr/sbin - XEN_ROOT=../.. include $(XEN_ROOT)/tools/Rules.mk +sbindir=/usr/sbin + CFLAGS += -Werror -g CFLAGS += -I $(XEN_XC) CFLAGS += -I $(XEN_LIBXC) diff --git a/tools/xenstat/libxenstat/Makefile b/tools/xenstat/libxenstat/Makefile index 7eea316133..214f50ba23 100644 --- a/tools/xenstat/libxenstat/Makefile +++ b/tools/xenstat/libxenstat/Makefile @@ -16,10 +16,6 @@ XEN_ROOT=../../.. include $(XEN_ROOT)/tools/Rules.mk LINUX_ROOT := $(XEN_ROOT)/linux-2.6-xen-sparse -INSTALL = install -INSTALL_PROG = $(INSTALL) -m0755 -D -INSTALL_DATA = $(INSTALL) -m0644 -D - prefix=/usr includedir=$(prefix)/include libdir=$(prefix)/lib diff --git a/tools/xenstat/xentop/Makefile b/tools/xenstat/xentop/Makefile index 273cb31e4e..b1220b2d33 100644 --- a/tools/xenstat/xentop/Makefile +++ b/tools/xenstat/xentop/Makefile @@ -18,10 +18,6 @@ ifneq ($(XENSTAT_XENTOP),y) all install xentop: else -INSTALL = install -INSTALL_PROG = $(INSTALL) -m0755 -D -INSTALL_DATA = $(INSTALL) -m0644 -D - prefix=/usr mandir=$(prefix)/share/man man1dir=$(mandir)/man1 diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile index 279a5a5354..772a2a8cf8 100644 --- a/tools/xenstore/Makefile +++ b/tools/xenstore/Makefile @@ -5,11 +5,6 @@ XEN_LIBXC = $(XEN_ROOT)/tools/libxc MAJOR = 3.0 MINOR = 0 -INSTALL = install -INSTALL_DATA = $(INSTALL) -m0644 -INSTALL_PROG = $(INSTALL) -m0755 -INSTALL_DIR = $(INSTALL) -d -m0755 - PROFILE=#-pg BASECFLAGS=-Wall -g -Werror # Make gcc generate dependencies. diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile index 0ab5e4c060..eafc5bba85 100644 --- a/tools/xentrace/Makefile +++ b/tools/xentrace/Makefile @@ -1,8 +1,3 @@ -INSTALL = install -INSTALL_PROG = $(INSTALL) -m0755 -INSTALL_DIR = $(INSTALL) -d -m0755 -INSTALL_DATA = $(INSTALL) -m0644 - XEN_ROOT=../.. include $(XEN_ROOT)/tools/Rules.mk diff --git a/xen/Rules.mk b/xen/Rules.mk index e319ffb619..d3bdc92e88 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -35,10 +35,6 @@ HDRS += $(wildcard $(BASEDIR)/include/public/*.h) HDRS += $(wildcard $(BASEDIR)/include/asm-$(TARGET_ARCH)/*.h) HDRS += $(wildcard $(BASEDIR)/include/asm-$(TARGET_ARCH)/$(TARGET_SUBARCH)/*.h) -INSTALL := install -INSTALL_DATA := $(INSTALL) -m0644 -INSTALL_DIR := $(INSTALL) -d -m0755 - include $(BASEDIR)/arch/$(TARGET_ARCH)/Rules.mk # Do not depend on auto-generated header files. -- cgit v1.2.3