aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Update Xen version to 4.0.2RELEASE-4.0.2Keir Fraser2011-06-142-2/+2
|
* Added signature for changeset 4c39fa80900dKeir Fraser2011-06-031-0/+1
|
* Added tag 4.0.2-rc6 for changeset 4c39fa80900dKeir Fraser2011-06-031-0/+1
|
* Update Xen version to 4.0.2-rc64.0.2-rc6Keir Fraser2011-06-032-2/+2
|
* x86: Hide CPUID leaf 7 from PV guests.Keir Fraser2011-06-032-0/+2
| | | | | | Signed-off-by: Keir Fraser <keir@xen.org> xen-unstable changeset: 23461:5839e797a130 xen-unstable date: Thu Jun 02 14:39:50 2011 +0100
* x86: Fix spurious_page_fault() for 1GB superpages.Keir Fraser2011-06-021-0/+2
| | | | | | | From: Xin Li <xin.li@intel.com> Signed-off-by: Keir Fraser <keir@xen.org> xen-unstable changeset: 23441:4d28306d6e33 xen-unstable date: Tue May 31 13:57:45 2011 +0100
* IOMMU: Fail if intremap is not available and iommu=required/force.Ian Campbell2011-05-282-2/+6
| | | | | | | | | | | Rather than sprinkling panic()s throughout the setup code hoist the check up into common code. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Signed-off-by: Keir Fraser <keir@xen.org> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> xen-unstable changeset: 23402:f979a1a69fe3 xen-unstable date: Thu May 26 08:18:44 2011 +0100
* libxc: obtain correct length of p2m during core dumpingMarkus Gross2011-05-281-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | while implementing core dumping functionality for the libxl driver of libvirt, I discovered an issue with mapping pages of a pv guest. After dumping the core of a pv guest the domain was not cleared up properly and some pages were not unmapped. This issue is similar to the one reported here: http://lists.xensource.com/archives/html/xen-devel/2011-05/msg01314.html In xc_domain_dumpcore_via_callback in the file xc_core.c the function xc_core_arch_map_p2m is called to map P2M_FL_ENTRIES pages to the variable p2m. But to unmap the pages later, the dinfo->p2m_size has to be set accordingly. This was not done, instead a variable named p2m_size was set. This way P2M_FL_ENTRIES was always zero and the pages were left mapped. Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> Committed-by: Ian Jackson <ian.jackson@eu.citrix.com> xen-unstable changeset: 23374:8bd7b5e98f2a xen-unstable date: Tue May 24 15:00:16 2011 +0100
* libxc: after saving, unmap correct amount for live_m2pJim Fehlig2011-05-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With some help from Olaf, I've finally got to the bottom of an issue I came across while trying to implement save/restore in the libvirt libxenlight driver. After issuing the save operation, the saved domain was not being cleaned up properly and left in this state from xl's perspective xen33:# xl list Name ID Mem VCPUs State Time(s) Domain-0 0 6821 8 r----- 122.5 (null) 2 2 2 --pssd 10.8 Checking the libvirtd /proc/$pid/maps I found this 7f3798984000-7f3798b86000 r--s 00002000 00:03 4026532097 /proc/xen/privcmd So not all all pages belonging to the domain were unmapped from libvirtd. In tools/libxc/xc_domain_save.c we found that P2M_FL_ENTRIES were being mapped but only P2M_FLL_ENTRIES were being unmapped. The attached patch changes the unmapping to use the same P2M_FL_ENTRIES macro. I'm not too familiar with this code though so posting here for review. I suspect this was not noticed before since most (all?) processes doing save terminate after the save and are not long-running like libvirtd. Ian Campbell writes: > Looks like I introduced this in 18558:ccf0205255e1, sorry! > > I guess it is also wrong in the error path out of map_and_save_p2m_table > and so we also need [another hunk]. This change should be backported to relevant earlier trees. -iwj From: Jim Fehlig <jfehlig@novell.com> From: Ian Campbell <Ian.Campbell@citrix.com> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com> Cc: Olaf Hering <olaf@aepfle.de> Acked-by: Ian Campbell <Ian.Campbell@citrix.com> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> Committed-by: Ian Jackson <ian.jackson@eu.citrix.com> xen-unstable changeset: 23373:171007b4e2c4 xen-unstable date: Tue May 24 14:50:00 2011 +0100
* Added signature for changeset d4cefc444b74Keir Fraser2011-05-241-0/+1
|
* Added tag 4.0.2-rc5 for changeset d4cefc444b74Keir Fraser2011-05-241-0/+1
|
* Update Xen version to 4.0.2-rc54.0.2-rc5Keir Fraser2011-05-241-1/+1
|
* drivers/passthrough: fix error paths in pci_add_device*()Tim Deegan2011-05-241-2/+8
| | | | | | | | | | | | | | | | | | When a device can't be allocated to dom0 by the IOMMU, don't leave dom0 in the "domain" field. It causes pci_remove_device() to crash trying to remove the dev from the domain's list of devices (and was probably the wrong thing to do anyway). Signed-off-by: Tim Deegan <Tim.Deegan@citrix.com> xen-unstable changeset: 23371:4326bcd88b33 xen-unstable date: Mon May 23 18:35:32 2011 +0100 drivers/passthrough: Revert 23352:ea48976517af -- incorrect bugfix. Signed-off-by: Keir Fraser <keir@xen.org> xen-unstable changeset: 23370:2e6719425265 xen-unstable date: Mon May 23 18:35:04 2011 +0100
* Fix Config.mk's cc-option for -Wno-* options.Keir Fraser2011-05-241-2/+12
| | | | | | | | | | | | | | | | | | | | These disable-warning options are handled specially by GCC: (a) they are ignored unless the compiler emits a warning; and (b) even then they produce a warning rather than an error To handle this, modify the test invocation of GCC to compile a fragment of code that will always provoke a warning (integer assigned to pointer). This works around (a) above. Then, we grep the compiler's stdout/stderr for the option-under-test, the presence of which would indicate an "unrecognized command-line option" warning/error. This works around (b) above, letting us distinguish between the "integer assigned to pointer" and "unrecognized command-line option" warnings. Signed-off-by: Keir Fraser <keir@xen.org> xen-unstable changeset: 23369:37c77bacb52a xen-unstable date: Mon May 23 17:38:28 2011 +0100
* Added signature for changeset 82f6fd38f5c2Keir Fraser2011-05-211-0/+1
|
* Added tag 4.0.2-rc4 for changeset 82f6fd38f5c2Keir Fraser2011-05-211-0/+1
|
* Update Xen version to 4.0.2-rc44.0.2-rc4Keir Fraser2011-05-212-2/+2
|
* gcc-4.6 compile fix: build with -Wno-unused-but-set-variableOlaf Hering2011-05-211-0/+1
| | | | | | | | | Avoid "error: variable 'unused' set but not used [-Werror=unused-but-set-variable]" with gcc 4.6. Signed-off-by: Olaf Hering <olaf@aepfle.de> xen-unstable changeset: 23368:0f670f5146c8 xen-unstable date: Sat May 21 07:55:46 2011 +0100
* x86: clear CPUID output of leaf 0xd for Dom0 when xsave is disabledKeir Fraser2011-05-202-0/+2
| | | | | | | | | | | | | | | | | Linux starting with 2.6.36 uses the XSAVEOPT instruction and has certain code paths that look only at the feature bit reported through CPUID leaf 0xd sub-leaf 1 (i.e. without qualifying the check with one evaluating leaf 4 output). Consequently the hypervisor ought to mimic actual hardware in clearing leaf 0xd output when not supporting xsave. Signed-off-by: Jan Beulich <jbeulich@novell.com> xen-unstable changeset: 23353:a768a10d32b4 xen-unstable date: Fri May 20 08:54:45 2011 +0100 Make this unconditional for 4.0 (no pv xsave support) and fix for domU guests as well (this was already okay in 4.1 and later). Signed-off-by: Keir Fraser <keir@xen.org>
* pci_remove_device: fix linked list disciplineTim Deegan2011-05-201-2/+2
| | | | | | Signed-off-by: Tim Deegan <Tim.Deegan@citrix.com> xen-unstable changeset: 23352:ea48976517af xen-unstable date: Fri May 20 08:52:22 2011 +0100
* x86-64: remove left over uses of .got entriesJan Beulich2011-05-162-2/+5
| | | | | | | | | These were caused by some declarations happening before the compiler would have seen the visibility pragma. Signed-off-by: Jan Beulich <jbeulich@novell.com> xen-unstable changeset: 23345:ba4bd20e581a xen-unstable date: Mon May 16 13:32:37 2011 +0100
* VT-d: Fix resource leaks on error pathsIgor Mammedov2011-05-161-2/+8
| | | | | | | | | | On error exit from functions, maped pages should be unmapped and acquired locks released. Signed-off-by: Igor Mammedov <imammedo@redhat.com> Acked-by: Allen Kay <allen.m.kay@intel.com> xen-unstable changeset: 23343:edcf8fc77b64 xen-unstable date: Mon May 16 13:29:24 2011 +0100
* x86/tsc: Remove incorrect assertion from cstate_restore_tsc()...Keir Fraser2011-05-162-3/+7
| | | | | | | | ..fix and move to write_tsc(). Signed-off-by: Keir Fraser <keir@xen.org> xen-unstable changeset: 23342:16d12acccacf xen-unstable date: Mon May 16 13:24:05 2011 +0100
* x86/ioapic: avoid gcc 4.6 warnings about uninitialised variablesIan Campbell2011-05-161-73/+63
| | | | | | | | | | | | | | | | | | | | | | | | | gcc 4.6 complains: io_apic.c: In function 'restore_IO_APIC_setup': /build/user-xen_4.1.0-3-amd64-zSon7K/xen-4.1.0/debian/build/build-hypervisor_amd64_amd64/xen/include/asm/io_apic.h:150:26: error: '*((void *)&entry+4)' may be used uninitialized in this function [-Werror=uninitialized] io_apic.c:221:32: note: '*((void *)&entry+4)' was declared here /build/user-xen_4.1.0-3-amd64-zSon7K/xen-4.1.0/debian/build/build-hypervisor_amd64_amd64/xen/include/asm/io_apic.h:150:26: error: 'entry' may be used uninitialized in this function [-Werror=uninitialized] io_apic.c:221:32: note: 'entry' was declared here cc1: all warnings being treated as errors Add functions to read/write an entire IO APIC entry using an explicit union to allow gcc to spot the initialisation. Reported as Debian bug #625438, thanks to Matthias Klose. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Acked-by: Jan Beulich <jbeulich@novell.com> xen-unstable changeset: 23341:87084ca76c9c xen-unstable date: Mon May 16 13:13:41 2011 +0100
* x86, vtd: [CVE-2011-1898] Protect against malicious MSIs from untrusted devices.Keir Fraser2011-05-124-5/+36
| | | | | | | | | | | | | | | | | | | | | | | In the absence of VT-d interrupt remapping support, a device can send arbitrary APIC messages to host CPUs. One class of attack that results is to confuse the hypervisor by delivering asynchronous interrupts to vectors that are expected to handle only synchronous traps/exceptions. We block this class of attack by: (1) setting APIC.TPR=0x10, to block all interrupts below vector 0x20. This blocks delivery to all architectural exception vectors. (2) checking APIC.ISR[vec] for vectors 0x80 (fast syscall) and 0x82 (hypercall). In these cases we BUG if we detect we are handling a hardware interrupt -- turning a potentially more severe infiltration into a straightforward system crash (i.e, DoS). Thanks to Invisible Things Lab <http://www.invisiblethingslab.com> for discovery and detailed investigation of this attack. Signed-off-by: Keir Fraser <keir@xen.org> xen-unstable changeset: 23337:cc91832a02c7 xen-unstable date: Thu May 12 16:39:31 2011 +0100
* x86: use compat hypercall handlers for calls from 32-bit HVM guestsTim Deegan2011-05-122-3/+20
| | | | | | | | | | | On 64-bit Xen, hypercalls from 32-bit HVM guests are handled as a special case, but not all the hypercalls are corrently redirected to their compat-mode wrappers. Use compat_* for xen_version, sched_op and set_timer_op for consistency. Signed-off-by: Tim Deegan <Tim.Deegan@citrix.com> xen-unstable changeset: 23333:fabdd682420c xen-unstable date: Thu May 12 09:13:18 2011 +0100
* tools/xm-test: portability fix: Avoid using == in /bin/sh scriptChristoph Egger2011-05-121-1/+1
| | | | | | | From: David Brownlee <abs@netbsd.org> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> xen-unstable changeset: 23328:6767d92dff13 xen-unstable date: Thu May 12 08:55:12 2011 +0100
* libxc: [CVE-2011-1583] pv kernel image validationIan Jackson2011-05-091-42/+93
| | | | | | | | | | | | | | | | | | | | | | The functions which interpret the kernel image supplied for a paravirtualised guest, and decompress it into memory when booting the domain, are incautious. Specifically: (i) Integer overflow in the decompression loop memory allocator might result in overrunning the buffer used for the decompressed image; (ii) Integer overflows and lack of checking of certain length fields can result in the loader reading its own address space beyond the size of the supplied kernel image file. (iii) Lack of error checking in the decompression loop can lead to an infinite loop. This patch fixes these problems. CVE-2011-1583. Signed-off-by: Ian Campbell <Ian.Campbell@eu.citrix.com> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com> Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
* x86: Clean up smp_call_function handling.Keir Fraser2011-05-091-9/+5
| | | | | | | | | We don't need so many communication fields between caller and handler. Signed-off-by: Keir Fraser <keir@xen.org> xen-unstable changeset: 23285:a7ac0a0170b0 xen-unstable date: Sun May 01 09:32:48 2011 +0100
* pv-grub: Fix for incorrect dom->p2m_host[] list initializationDaniel Kiper2011-04-271-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | Introduction of Linux Kernel git commit ceefccc93932b920a8ec6f35f596db05202a12fe (x86: default CONFIG_PHYSICAL_START and CONFIG_PHYSICAL_ALIGN to 16 MB) revealed deeply hidden bug in pv-grub. During kernel load stage dom->p2m_host[] list has been incorrectly initialized. At the beginning of kernel load stage dom->p2m_host[] list is populated with current PFN->MFN layout. Later during memory allocation (memory is allocated page by page in kexec_allocate()) page order is changed to establish linear layout in new domain. It is done by exchanging subsequent MFNs with newly allocated MFNs. dom->p2m_host[] list is indexed by currently requested PFN (it is incremented from 0) and PFN of newly allocated paged. If PFN of newly allocated page is less than currently requested PFN then earlier allocated MFN is overwritten which leads to domain crash later. This patch corrects that issue. If PFN of newly allocated page is less then currently requested PFN then relevant PFN/MFN pair is properly calculated and usual exchange occurs later. Signed-off-by: Daniel Kiper <dkiper@net-space.pl> Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org> xen-unstable changeset: 23249:83fe79c0225f xen-unstable date: Wed Apr 27 13:29:14 2011 +0100
* x86: No need for disable_tsc_sync when full 64-bit TSC cannot be writtenKeir Fraser2011-04-263-17/+0
| | | | | | During boot we only write zero to the TSCs, which is safe. Signed-off-by: Keir Fraser <keir@xen.org>
* x86: Bail from hpet_disable_legacy_broadcast() if legacy_hpet_event is ↵Keir Fraser2011-04-261-0/+3
| | | | | | | | uninitialised. Signed-off-by: Keir Fraser <keir@xen.org> xen-4.1-testing changeset: 23034:7c7ef1b6f4e5 xen-4.1-testing date: Tue Apr 26 14:11:18 2011 +0100
* x86: don't write_tsc() non-zero values on CPUs updating only the lower 32 bitsKeir Fraser2011-04-255-2/+88
| | | | | | | | | | | | This means suppressing the uses in time_calibration_tsc_rendezvous(), cstate_restore_tsc(), and synchronize_tsc_slave(), and fixes a boot hang of Linux Dom0 when loading processor.ko on such systems that have support for C states above C1. Signed-off-by: Jan Beulich <jbeulich@novell.com> Signed-off-by: Keir Fraser <keir@xen.org> xen-unstable changeset: 23228:1329d99b4f16 xen-unstable date: Fri Apr 15 08:52:08 2011 +0100
* Added signature for changeset 5a74ec3e0ccaKeir Fraser2011-04-131-0/+1
|
* Added tag 4.0.2-rc3 for changeset 5a74ec3e0ccaKeir Fraser2011-04-131-0/+1
|
* Update Xen version to 4.0.2-rc34.0.2-rc3Keir Fraser2011-04-132-2/+2
|
* x86, amd, MTRR: correct DramModEn bit of SYS_CFG MSRWei Huang2011-04-071-0/+28
| | | | | | | | | | Some buggy BIOS might set SYS_CFG DramModEn bit to 1, which can cause unexpected behavior on AMD platforms. This patch clears DramModEn bit if it is 1. Signed-off-by: Wei Huang <wei.huang2@amd.com> xen-unstable changeset: 23153:8fb61c9ebe49 xen-unstable date: Wed Apr 06 09:01:31 2011 +0100
* X86: Fix mce offline page bugLiu, Jinsong2011-04-071-10/+1
| | | | | | | | | | | | | c/s 19913 break mce offline page logic: For page_state_is(pg, free), it's impossible to trigger the case; For page_state_is(pg, offlined), it in fact didn't offline related page; This patch fix the bug, and remove an ambiguous comment. Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com> xen-unstable changeset: 23177:d8bb2de119de xen-unstable date: Thu Apr 07 12:12:01 2011 +0100
* x86/hvm: load CPU structures from xen versions <=3.4George Dunlap2011-04-071-1/+126
| | | | | | | | | | | | | Xen 4.0 added "msr_tsc_aux" in the middle of the hvm_hw_cpu structure, making it incompatible with pre-3.4 savefiles. This patch uses the recently introduced backwards-compatibility infrastructure to convert the old to the new. Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com> Acked-by: Tim Deegan <Tim.Deegan@citrix.com> Committed-by: Tim Deegan <Tim.Deegan@citrix.com> xen-unstable changeset: 23172:dc8b05d22a59 xen-unstable date: Wed Apr 06 11:40:54 2011 +0100
* hvm: infrastructure for backwards-compatible loadingGeorge Dunlap2011-04-072-8/+36
| | | | | | | | | | | | | | | | | | | | | | | | The hvm_save code is used to save and restore hypervisor-related hvm state, either for classic save/restore, or for migration (including remus). This is meant to be backwards-compatible across some hypervisor versions; but if it does change, there is no way to handle the old format as well as the new. This patch introduces the infrastructure to allow a single older version ("compat") of any given "save type" to be defined, along with a function to turn the "old" version into the "new" version. If the size check fails for the "normal" version, it will check the "compat" version, and if it matches, will read the old entry and call the conversion function. This patch involves some preprocessor hackery, but I'm only extending the hackery that's already there. Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com> Acked-by: Tim Deegan <Tim.Deegan@citrix.com> Committed-by: Tim Deegan <Tim.Deegan@citrix.com> xen-unstable changeset: 23171:6a5830de7b54 xen-unstable date: Wed Apr 06 11:40:51 2011 +0100
* hvm save: Introduce hvm_load_entry_zeroextend().Keir Fraser2011-04-073-11/+22
| | | | | | | | | | | | In certain cases this will allow us to load old HVM save images where an HVM saved chunk has subsequently been extended with new fields. Rather than fail to load the chunk, we can pad the extended structure with zeroes, if the caller knows how to handle that. Signed-off-by: Keir Fraser <keir@xen.org> Acked-by: Tim Deegan <Tim.Deegan@citrix.com> xen-unstable changeset: 22524:1f08b2932a52 xen-unstable date: Wed Dec 15 10:21:05 2010 +0000
* hvm save: Move some inline functions into common/hvm/save.cKeir Fraser2011-04-072-62/+81
| | | | | | Signed-off-by: Keir Fraser <keir@xen.org> xen-unstable changeset: 22523:6dda9f988ef3 xen-unstable date: Wed Dec 15 10:15:45 2010 +0000
* xen: fix reloc.S generation for non-gnu toolchainChristoph Egger2011-04-021-2/+2
| | | | | | | | The output of AT&T UNIX and GNU od(1) are different. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> xen-unstable changeset: 23130:0e88c781a8a8 xen-unstable date: Sat Apr 02 15:53:35 2011 +0100
* x86: __pirq_guest_eoi() must check it is called for a fullyKeir Fraser2011-04-021-0/+6
| | | | | | | | guest-bound irq before accessing desc->action. Signed-off-by: Keir Fraser <keir@xen.org> xen-unstable changeset: 23103:48dac730a93b xen-unstable date: Sat Mar 26 09:42:01 2011 +0000
* tools/blktap, blktap2: include <sys/mount.h> instead of <linux/fs.h>Ian Campbell2011-03-262-3/+3
| | | | | | | | | | | | | | The former is a userspace sanitised header which contains the definitions we need. In some distros linux/fs.h defines WRITE which conflicts with blktaps own use of that name. Also there is no reason to use <linux/errno.h> over the more normal <errno.h>. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Committed-by: Ian Jackson <ian.jackson@eu.citrix.com> xen-unstable changeset: 22765:0dbad563a659 xen-unstable date: Mon Jan 17 17:14:20 2011 +0000
* init.d: Fix xencommons init script chkconfig configurationKeir Fraser2011-03-251-1/+1
| | | | | | | | | | | | | | | | Fix the xencommons init script chkconfig configuration since the priority was missing here and chkconfig was complaining about invalid chkconfig script so I added both start and stop priorities to the chkconfig line and it was working fine, the script was successfully added to chkconfig when using `chkconfig --add xencommons` and management using the chkconfig utility was now possible. Tested on RHEL-5 Server with Xen-4.1-unstable installed, running on PVops kernel 2.6.32.15 and it was working fine. Signed-off-by: Michal Novotny <minovotn@redhat.com> xen-unstable changeset: 21657:e2f5e4f3481c xen-unstable date: Tue Jun 22 16:22:30 2010 +0100
* x86: run-time callers of map_pages_to_xen() must check for errorsJan Beulich2011-03-154-50/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | Again, (out-of-memory) errors must not cause hypervisor crashes, and hence ought to be propagated. This also adjusts the cache attribute changing loop in get_page_from_l1e() to not go through an unnecessary iteration. While this could be considered mere cleanup, it is actually a requirement for the subsequent now necessary error recovery path. Also make a few functions static, easing the check for potential callers needing adjustment. Signed-off-by: Jan Beulich <jbeulich@novell.com> xen-unstable changeset: 22997:5f28dcea1355 xen-unstable date: Wed Mar 09 16:15:36 2011 +0000 x86: don't BUG() post-boot in alloc_xen_pagetable() Instead, propagate the condition to the caller, all of which also get adjusted to check for that situation. Signed-off-by: Jan Beulich <jbeulich@novell.com> xen-unstable changeset: 22996:1eeccafe9042 xen-unstable date: Wed Mar 09 16:14:59 2011 +0000
* _csched_cpu_pick(): don't return CPUs outside vCPU's affinity maskJan Beulich2011-03-141-0/+1
| | | | | | | | | This fixes a fairly blatant bug I introduced in c/s 20377:cff23354d026 - I wonder how this went unnoticed for so long. Signed-off-by: Jan Beulich <jbeulich@novell.com> xen-unstable changeset: 23039:c40da47621d8 xen-unstable date: Mon Mar 14 17:19:22 2011 +0000
* x86_64: fix error checking in arch_set_info_guest()Tim Deegan2011-03-141-0/+5
| | | | | | | | | | Cannot specify user mode execution without specifying user-mode pagetables. Signed-off-by: Tim Deegan <Tim.Deegan@citrix.com> Acked-by: Keir Fraser <keir@xen.org> xen-unstable changeset: 23034:c79aae866ad8 xen-unstable date: Mon Mar 14 16:59:49 2011 +0000
* libxc: fix incorrect scanning of pfn array in pagebuf during migrationShriram Rajagopalan2011-03-141-4/+4
| | | | | | | | | | | | | | | | | | | | | | xc_domain_restore.c:apply_batch function makes two passes over the pfn_types array in pagebuf to allocate the needed MFNs. The curbatch parameter to this function specifies the array offset in pfn_types, from where the current scan should begin. But this variable is not taken into account (index always starts at 0) during the two passes. While this [bug] does not manifest itsef during save/restore or live migration, under Remus, xc_domain_restore fails due to corrupt guest page tables. (This appears to have been broken by 21588:6c3d8aec202d which reverted two changesets from before Remus support was added and hence reintroduced some none-Remus compatible bits.) Signed-off-by: Shriram Rajagopalan <rshriram@cs.ubc.ca> Acked-by: Ian Campbell <ian.campbell@citrix.com> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> Committed-by: Ian Jackson <ian.jackson@eu.citrix.com> xen-unstable changeset: 22967:5bc39222773d xen-unstable date: Thu Mar 03 16:55:27 2011 +0000