diff options
| author | Jan Beulich <jbeulich@suse.com> | 2012-12-07 13:40:46 +0100 |
|---|---|---|
| committer | Jan Beulich <jbeulich@suse.com> | 2012-12-07 13:40:46 +0100 |
| commit | 7e98fc5ba662fc4c6323b865e5c466c125333056 (patch) | |
| tree | 741dc7c141113f3406e17fe80e4a3ea47e1f24e9 /xen/arch/x86/mm.c | |
| parent | 4aa8723b7a9fa57750087e3d3ba54fe7aedff494 (diff) | |
| download | xen-7e98fc5ba662fc4c6323b865e5c466c125333056.tar.gz xen-7e98fc5ba662fc4c6323b865e5c466c125333056.tar.bz2 xen-7e98fc5ba662fc4c6323b865e5c466c125333056.zip | |
x86: properly fail mmuext ops when get_page_from_gfn() fails
I noticed this inconsistency while analyzing the code for XSA-32.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
Diffstat (limited to 'xen/arch/x86/mm.c')
| -rw-r--r-- | xen/arch/x86/mm.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index ab94b022c6..e2b74be6d4 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -2776,7 +2776,7 @@ long do_mmuext_op( page = get_page_from_gfn(pg_owner, op.arg1.mfn, NULL, P2M_ALLOC); if ( unlikely(!page) ) { - rc = -EINVAL; + okay = 0; break; } @@ -2836,6 +2836,7 @@ long do_mmuext_op( page = get_page_from_gfn(pg_owner, op.arg1.mfn, NULL, P2M_ALLOC); if ( unlikely(!page) ) { + okay = 0; MEM_LOG("Mfn %lx bad domain", op.arg1.mfn); break; } |