diff options
| author | Ian Jackson <Ian.Jackson@eu.citrix.com> | 2010-07-21 16:50:15 +0100 |
|---|---|---|
| committer | Ian Jackson <Ian.Jackson@eu.citrix.com> | 2010-07-21 16:50:15 +0100 |
| commit | 389da317e2f3ab4232e2ea5c238f7ff1658e6c23 (patch) | |
| tree | 09168450c5516716cde80416eedbaf395fdaae89 /tools/libxl/libxl_internal.h | |
| parent | 698271c2e6ae016596d919b41b74c7e0e6ae28c0 (diff) | |
| download | xen-389da317e2f3ab4232e2ea5c238f7ff1658e6c23.tar.gz xen-389da317e2f3ab4232e2ea5c238f7ff1658e6c23.tar.bz2 xen-389da317e2f3ab4232e2ea5c238f7ff1658e6c23.zip | |
Revert 91c486918e02 "More consistent error handling in libxl"
I'm afraid this pattern is wrong for two reasons. Firstly,
xc_domain_pause and functions like it do not return XC_ERROR_* values.
They typically return -1 on error, and set errno.
Secondly, the error codes from libxc are not really all that useful.
They mostly serve to identify where the error originated.
See the comment in xenctrl.h near line 70.
Diffstat (limited to 'tools/libxl/libxl_internal.h')
| -rw-r--r-- | tools/libxl/libxl_internal.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index 129e22cd50..10d45c70e6 100644 --- a/tools/libxl/libxl_internal.h +++ b/tools/libxl/libxl_internal.h @@ -222,8 +222,5 @@ char *libxl_abs_path(struct libxl_ctx *ctx, char *s, const char *path); #define XL_LOG_WARNING XTL_WARN #define XL_LOG_ERROR XTL_ERROR -/* Error handling */ -int libxl_xc_error(int xc_err); - #endif |