diff options
| author | Ian Jackson <ian.jackson@eu.citrix.com> | 2013-04-09 15:44:07 +0100 |
|---|---|---|
| committer | Ian Jackson <Ian.Jackson@eu.citrix.com> | 2013-04-09 15:44:07 +0100 |
| commit | c70ce4614ea99bc31450141359ec6c5c53a9f7b2 (patch) | |
| tree | e0dd36c9f9e1e36ffa28b8ad180b361058657c85 /tools/lib/sys_string.h | |
| parent | 0984c2b63a7c3e9dfa770b29dac51a5124aecaab (diff) | |
| download | xen-c70ce4614ea99bc31450141359ec6c5c53a9f7b2.tar.gz xen-c70ce4614ea99bc31450141359ec6c5c53a9f7b2.tar.bz2 xen-c70ce4614ea99bc31450141359ec6c5c53a9f7b2.zip | |
libxl: run libxl__arch_domain_create() much earlier.
Among other things, arch_domain_create() sets the shadow(/hap/p2m)
memory allocation, which must happen after vcpus are assigned (or the
shadow op will fail) but before memory is allocated (or we might run
out of p2m memory).
libxl__build_pre(), which already sets similar things like maxmem,
semes like a reasonable spot for it. That needed a bit of plumbing to
get the right datastructure from the caller.
As a side-effect, the return code from libxl__arch_domain_create() is
no longer ignored.
This bug was analysed in:
From: "Jan Beulich" <JBeulich@xxxxxxxx>
"Re: [Xen-devel] [xen-unstable test] 16788: regressions - FAIL"
Date: Mon, 04 Mar 2013 16:34:53 +0000
http://lists.xen.org/archives/html/xen-devel/2013-03/msg00191.html
Reported-by: Jan Beulich <JBeulich@suse.com>
Signed-off-by: Tim Deegan <tim@xen.org>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
(Cherry-picked from 650354dbc2626b643c12873275ca67782f1382c8.)
Conflicts:
tools/libxl/libxl_dom.c
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Diffstat (limited to 'tools/lib/sys_string.h')
0 files changed, 0 insertions, 0 deletions
