diff options
| author | Ben Guthro <benjamin.guthro@citrix.com> | 2013-04-29 16:08:16 +0200 |
|---|---|---|
| committer | Jan Beulich <jbeulich@suse.com> | 2013-04-29 16:08:16 +0200 |
| commit | 7fe762b3f06f0e81ce5b3456dc61fc004562ef21 (patch) | |
| tree | cdf2ec345944298244659024affd1b9dce13568d /tools/lib/sys_string.h | |
| parent | 33c9aa46e2a1cb94fdd5e14374060b8c2bd7e5a6 (diff) | |
| download | xen-7fe762b3f06f0e81ce5b3456dc61fc004562ef21.tar.gz xen-7fe762b3f06f0e81ce5b3456dc61fc004562ef21.tar.bz2 xen-7fe762b3f06f0e81ce5b3456dc61fc004562ef21.zip | |
x86/S3: Fix cpu pool scheduling after suspend/resume
This review is another S3 scheduler problem with the system_state
variable introduced with the following changeset:
http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=269f543ea750ed567d18f2e819e5d5ce58eda5c5
Specifically, the cpu_callback function that takes the CPU down during
suspend, and back up during resume. We were seeing situations where,
after S3, only CPU0 was in cpupool0. Guest performance suffered
greatly, since all vcpus were only on a single pcpu. Guests under high
CPU load showed the problem much more quickly than an idle guest.
Removing this if condition forces the CPUs to go through the expected
online/offline state, and be properly scheduled after S3.
This also includes a necessary partial change proposed earlier by
Tomasz Wroblewski here:
http://lists.xen.org/archives/html/xen-devel/2013-01/msg02206.html
It should also resolve the issues discussed in this thread:
http://lists.xen.org/archives/html/xen-devel/2012-11/msg01801.html
Signed-off-by: Ben Guthro <benjamin.guthro@citrix.com>
Acked-by: Juergen Gross <juergen.gross@ts.fujitsu.com>
master commit: 9aa356bc9f7533c3cb7f02c823f532532876d444
master date: 2013-04-19 12:29:01 +0200
Diffstat (limited to 'tools/lib/sys_string.h')
0 files changed, 0 insertions, 0 deletions