diff options
| author | Jan Beulich <jbeulich@suse.com> | 2013-10-11 09:31:16 +0200 |
|---|---|---|
| committer | Jan Beulich <jbeulich@suse.com> | 2013-10-11 09:31:16 +0200 |
| commit | 6fd9b0361e2eb5a7f12bdd5cbf7e42c0d1937d26 (patch) | |
| tree | d38d718fbf296ee356eb3fdb68f67070cb62dbc1 | |
| parent | 4b46e7be783df641b2889e514e85643febd378c2 (diff) | |
| download | xen-6fd9b0361e2eb5a7f12bdd5cbf7e42c0d1937d26.tar.gz xen-6fd9b0361e2eb5a7f12bdd5cbf7e42c0d1937d26.tar.bz2 xen-6fd9b0361e2eb5a7f12bdd5cbf7e42c0d1937d26.zip | |
x86: check for canonical address before doing page walks
... as there doesn't really exists any valid mapping for them.
Particularly in the case of do_page_walk() this also avoids returning
non-NULL for such invalid input.
Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Keir Fraser <keir@xen.org>
| -rw-r--r-- | xen/arch/x86/x86_64/mm.c | 2 | ||||
| -rw-r--r-- | xen/arch/x86/x86_64/traps.c | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c index 84a2434da5..2bdbad09a9 100644 --- a/xen/arch/x86/x86_64/mm.c +++ b/xen/arch/x86/x86_64/mm.c @@ -73,7 +73,7 @@ void *do_page_walk(struct vcpu *v, unsigned long addr) l2_pgentry_t l2e, *l2t; l1_pgentry_t l1e, *l1t; - if ( is_hvm_vcpu(v) ) + if ( is_hvm_vcpu(v) || !is_canonical_address(addr) ) return NULL; l4t = map_domain_page(mfn); diff --git a/xen/arch/x86/x86_64/traps.c b/xen/arch/x86/x86_64/traps.c index 1cc977c757..0316d7c4ac 100644 --- a/xen/arch/x86/x86_64/traps.c +++ b/xen/arch/x86/x86_64/traps.c @@ -170,6 +170,8 @@ void show_page_walk(unsigned long addr) l1_pgentry_t l1e, *l1t; printk("Pagetable walk from %016lx:\n", addr); + if ( !is_canonical_address(addr) ) + return; l4t = map_domain_page(mfn); l4e = l4t[l4_table_offset(addr)]; |