aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthew Daley <mattjd@gmail.com>2013-09-10 23:12:45 +1200
committerIan Jackson <Ian.Jackson@eu.citrix.com>2013-10-10 16:59:41 +0100
commit4d747f7c638b6cc6fce8f98ce89b53b4eefc991a (patch)
tree6c85f8e09b66a8acf5d5b37ef88ff127911dd408
parent8f749b254def91001124367d687e9fc6a2793f6b (diff)
downloadxen-4d747f7c638b6cc6fce8f98ce89b53b4eefc991a.tar.gz
xen-4d747f7c638b6cc6fce8f98ce89b53b4eefc991a.tar.bz2
xen-4d747f7c638b6cc6fce8f98ce89b53b4eefc991a.zip
tools/ocaml: fix erroneous free of cpumap in stub_xc_vcpu_getaffinity
Not sure how it got there... Coverity-ID: 1056196 This is CVE-2013-4370 / XSA-69 Signed-off-by: Matthew Daley <mattjd@gmail.com> Acked-by: Ian Campbell <ian.campbell@citrix.com> (cherry picked from commit 3cd10fd21220f2b814324e6e732004f8f0487d0a) (cherry picked from commit debfacf7d68de8e39a06ebc7f7b22386b28ce6fb)
-rw-r--r--tools/ocaml/libs/xc/xenctrl_stubs.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c
index 0e26ae9de7..a144313708 100644
--- a/tools/ocaml/libs/xc/xenctrl_stubs.c
+++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
@@ -461,8 +461,6 @@ CAMLprim value stub_xc_vcpu_getaffinity(value xch, value domid,
retval = xc_vcpu_getaffinity(_H(xch), _D(domid),
Int_val(vcpu), c_cpumap);
- free(c_cpumap);
-
if (retval < 0) {
free(c_cpumap);
failwith_xc(_H(xch));