diff options
| author | Tomasz Wroblewski <tomasz.wroblewski@citrix.com> | 2013-09-06 14:48:49 +0200 |
|---|---|---|
| committer | Jan Beulich <jbeulich@suse.com> | 2013-09-06 14:48:49 +0200 |
| commit | 4917ef594512e1f3b481bfbef83cc5ed743a465c (patch) | |
| tree | 3aed3ec1a7785d18838cb3bb7aa3f56228100fb4 | |
| parent | 22143eb77de49ab265f6a00e6413580d0d452594 (diff) | |
| download | xen-4917ef594512e1f3b481bfbef83cc5ed743a465c.tar.gz xen-4917ef594512e1f3b481bfbef83cc5ed743a465c.tar.bz2 xen-4917ef594512e1f3b481bfbef83cc5ed743a465c.zip | |
Fix inactive timer list corruption on second S3 resume
init_timer cannot be safely called multiple times on same timer since it does memset(0)
on the structure, erasing the auxiliary member used by linked list code. This breaks
inactive timer list in common/timer.c.
Moved resume_timer initialisation to ns16550_init_postirq, so it's only done once.
Signed-off-by: Tomasz Wroblewski <tomasz.wroblewski@citrix.com>
Acked-by: Keir Fraser <keir@xen.org>
master commit: 9e2c5938246546a5b3f698b7421640d85602b994
master date: 2013-08-28 10:18:39 +0200
| -rw-r--r-- | xen/drivers/char/ns16550.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index 12c5f84eb0..342982cb1e 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -125,6 +125,8 @@ static struct ns16550 { #define RESUME_DELAY MILLISECS(10) #define RESUME_RETRIES 100 +static void ns16550_delayed_resume(void *data); + static char ns_read_reg(struct ns16550 *uart, int reg) { if ( uart->remapped_io_base == NULL ) @@ -306,6 +308,7 @@ static void __init ns16550_init_postirq(struct serial_port *port) serial_async_transmit(port); init_timer(&uart->timer, ns16550_poll, port, 0); + init_timer(&uart->resume_timer, ns16550_delayed_resume, port, 0); /* Calculate time to fill RX FIFO and/or empty TX FIFO for polling. */ bits = uart->data_bits + uart->stop_bits + !!uart->parity; @@ -392,7 +395,6 @@ static void ns16550_resume(struct serial_port *port) if ( ns16550_ioport_invalid(uart) ) { delayed_resume_tries = RESUME_RETRIES; - init_timer(&uart->resume_timer, ns16550_delayed_resume, port, 0); set_timer(&uart->resume_timer, NOW() + RESUME_DELAY); } else |