diff options
author | Stefano Stabellini <stefano.stabellini@eu.citrix.com> | 2012-05-29 16:36:45 +0100 |
---|---|---|
committer | Stefano Stabellini <stefano.stabellini@eu.citrix.com> | 2012-05-29 16:36:45 +0100 |
commit | 06c0bc127b521e9cf9f4b9a06e5b1960e38458b6 (patch) | |
tree | fbf8c52c20ea7ec47e80f051281cf8655287c93c | |
parent | 65e5514ba8c545cfb75010a3cf33fa22ae0799e7 (diff) | |
download | xen-06c0bc127b521e9cf9f4b9a06e5b1960e38458b6.tar.gz xen-06c0bc127b521e9cf9f4b9a06e5b1960e38458b6.tar.bz2 xen-06c0bc127b521e9cf9f4b9a06e5b1960e38458b6.zip |
libxl: make libxl_device_disk_local_attach/detach internal functions
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Campbell <ian.campbell@citrix.com>
-rw-r--r-- | tools/libxl/libxl.c | 11 | ||||
-rw-r--r-- | tools/libxl/libxl.h | 7 | ||||
-rw-r--r-- | tools/libxl/libxl_bootloader.c | 4 | ||||
-rw-r--r-- | tools/libxl/libxl_internal.h | 9 |
4 files changed, 14 insertions, 17 deletions
diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 0e281a635d..a28c0f9bda 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -1735,9 +1735,9 @@ out: return ret; } -char * libxl_device_disk_local_attach(libxl_ctx *ctx, libxl_device_disk *disk) +char * libxl__device_disk_local_attach(libxl__gc *gc, libxl_device_disk *disk) { - GC_INIT(ctx); + libxl_ctx *ctx = gc->owner; char *dev = NULL; char *ret = NULL; int rc; @@ -1792,11 +1792,10 @@ char * libxl_device_disk_local_attach(libxl_ctx *ctx, libxl_device_disk *disk) out: if (dev != NULL) ret = strdup(dev); - GC_FREE; return ret; } -int libxl_device_disk_local_detach(libxl_ctx *ctx, libxl_device_disk *disk) +int libxl__device_disk_local_detach(libxl__gc *gc, libxl_device_disk *disk) { /* Nothing to do for PHYSTYPE_PHY. */ @@ -1804,10 +1803,6 @@ int libxl_device_disk_local_detach(libxl_ctx *ctx, libxl_device_disk *disk) * For other device types assume that the blktap2 process is * needed by the soon to be started domain and do nothing. */ - /* - * FIXME - * This appears to leak the disk in failure paths - */ return 0; } diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h index 9c03f15c31..3a0d71dc69 100644 --- a/tools/libxl/libxl.h +++ b/tools/libxl/libxl.h @@ -654,13 +654,6 @@ int libxl_device_disk_getinfo(libxl_ctx *ctx, uint32_t domid, */ int libxl_cdrom_insert(libxl_ctx *ctx, uint32_t domid, libxl_device_disk *disk); -/* - * Make a disk available in this (the control) domain. Returns path to - * a device. - */ -char * libxl_device_disk_local_attach(libxl_ctx *ctx, libxl_device_disk *disk); -int libxl_device_disk_local_detach(libxl_ctx *ctx, libxl_device_disk *disk); - /* Network Interfaces */ int libxl_device_nic_add(libxl_ctx *ctx, uint32_t domid, libxl_device_nic *nic); int libxl_device_nic_remove(libxl_ctx *ctx, uint32_t domid, diff --git a/tools/libxl/libxl_bootloader.c b/tools/libxl/libxl_bootloader.c index 6d83bb561e..30b012d623 100644 --- a/tools/libxl/libxl_bootloader.c +++ b/tools/libxl/libxl_bootloader.c @@ -225,7 +225,7 @@ static void bootloader_cleanup(libxl__egc *egc, libxl__bootloader_state *bl) if (bl->outputdir) libxl__remove_directory(gc, bl->outputdir); if (bl->diskpath) { - libxl_device_disk_local_detach(CTX, bl->disk); + libxl__device_disk_local_detach(gc, bl->disk); free(bl->diskpath); bl->diskpath = 0; } @@ -344,7 +344,7 @@ void libxl__bootloader_run(libxl__egc *egc, libxl__bootloader_state *bl) goto out; } - bl->diskpath = libxl_device_disk_local_attach(CTX, bl->disk); + bl->diskpath = libxl__device_disk_local_attach(gc, bl->disk); if (!bl->diskpath) { rc = ERROR_FAIL; goto out; diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index bbc21496a1..6ef39061cc 100644 --- a/tools/libxl/libxl_internal.h +++ b/tools/libxl/libxl_internal.h @@ -1278,6 +1278,15 @@ _hidden char *libxl__blktap_devpath(libxl__gc *gc, */ _hidden void libxl__device_destroy_tapdisk(libxl__gc *gc, char *be_path); +/* + * Make a disk available in this (the control) domain. Returns path to + * a device. + */ +_hidden char * libxl__device_disk_local_attach(libxl__gc *gc, + libxl_device_disk *disk); +_hidden int libxl__device_disk_local_detach(libxl__gc *gc, + libxl_device_disk *disk); + _hidden char *libxl__uuid2string(libxl__gc *gc, const libxl_uuid uuid); struct libxl__xen_console_reader { |