diff options
| author | Andrew Cooper <andrew.cooper3@citrix.com> | 2013-04-02 11:00:22 +0200 |
|---|---|---|
| committer | Jan Beulich <jbeulich@suse.com> | 2013-04-02 11:00:22 +0200 |
| commit | d82be94efbf8e2721f5957fe459fc296198ffc80 (patch) | |
| tree | 6d6c68ce9604bd7c03abed2cb1cd86d60bb7d384 | |
| parent | 67e5f2ad3885d1ce27b02732f11e3010ee58d540 (diff) | |
| download | xen-d82be94efbf8e2721f5957fe459fc296198ffc80.tar.gz xen-d82be94efbf8e2721f5957fe459fc296198ffc80.tar.bz2 xen-d82be94efbf8e2721f5957fe459fc296198ffc80.zip | |
ACPI/APEI: Unlock apei_iomaps_lock on error path
This causes deadlocks during early boot on hardware with broken/buggy
APEI implementations, such as a Dell Poweredge 2950 with the latest
currently available BIOS.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Don't use goto or another special error path, as handling the error
case in normal flow is quite simple.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
master changeset: 0611689d9153227831979c7bafe594214b8505a3
master date: 2013-03-22 09:43:38 +0100
| -rw-r--r-- | xen/drivers/acpi/apei/apei-io.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/xen/drivers/acpi/apei/apei-io.c b/xen/drivers/acpi/apei/apei-io.c index d57035bb5d..f0f4636b19 100644 --- a/xen/drivers/acpi/apei/apei-io.c +++ b/xen/drivers/acpi/apei/apei-io.c @@ -146,10 +146,8 @@ static void __init apei_post_unmap(paddr_t paddr, unsigned long size) spin_lock_irqsave(&apei_iomaps_lock, flags); map = __apei_find_iomap(paddr, size); - if (!map) - return; - - list_del(&map->list); + if (map) + list_del(&map->list); spin_unlock_irqrestore(&apei_iomaps_lock, flags); xfree(map); |