diff options
| author | Jan Beulich <jbeulich@suse.com> | 2013-04-02 11:23:05 +0200 |
|---|---|---|
| committer | Jan Beulich <jbeulich@suse.com> | 2013-04-02 11:23:05 +0200 |
| commit | 8d870e41ed8cd624c5390530ca5bf32dc267cb7f (patch) | |
| tree | 02eeed6a8147b4938946a50b02e3a2e41e8297bf | |
| parent | 7947b74a37020b15a69e2aa1e1e5ede9516c77cd (diff) | |
| download | xen-8d870e41ed8cd624c5390530ca5bf32dc267cb7f.tar.gz xen-8d870e41ed8cd624c5390530ca5bf32dc267cb7f.tar.bz2 xen-8d870e41ed8cd624c5390530ca5bf32dc267cb7f.zip | |
x86/EFI: permit setting variable with non-zero attributes
This must have been a copy-and-paste mistake - get_variable uses
op->misc as output only, and wants to make sure it's zero for future
extensibility. For set_variable, this is an input though, and hence
the check is wrong.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
master changeset: 78380c34dfeb27da3d0222bcb7232c5d8e2f5b30
master date: 2013-03-27 08:46:28 +0100
| -rw-r--r-- | xen/arch/x86/efi/runtime.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/xen/arch/x86/efi/runtime.c b/xen/arch/x86/efi/runtime.c index 1dbe2dbd25..9fbf5b70b4 100644 --- a/xen/arch/x86/efi/runtime.c +++ b/xen/arch/x86/efi/runtime.c @@ -380,9 +380,6 @@ int efi_runtime_call(struct xenpf_efi_runtime_call *op) long len; unsigned char *data; - if ( op->misc ) - return -EINVAL; - len = gwstrlen(guest_handle_cast(op->u.set_variable.name, CHAR16)); if ( len < 0 ) return len; |