diff options
| author | Stefano Stabellini <stefano.stabellini@eu.citrix.com> | 2011-05-12 09:20:09 +0100 |
|---|---|---|
| committer | Stefano Stabellini <stefano.stabellini@eu.citrix.com> | 2011-05-12 09:20:09 +0100 |
| commit | 854fee1003c88be377a8ee03f324f79ce41ea566 (patch) | |
| tree | 675c297d8fae3cf34d6d54cf6ef218e163891347 | |
| parent | e8234cc8ce43d70a7c23ece675b3611eb4d8a0eb (diff) | |
| download | xen-854fee1003c88be377a8ee03f324f79ce41ea566.tar.gz xen-854fee1003c88be377a8ee03f324f79ce41ea566.tar.bz2 xen-854fee1003c88be377a8ee03f324f79ce41ea566.zip | |
x86/hvm: pv-on-hvm: fix de/assert_irq checks
The checks in assert_irq and deassert_irq to distinguish interrupts
that have been remapped onto event channels from the others that have
to be injected using the emulated lapic are wrong.
Fix the condition checks using the convenient hvm_domain_use_pirq
function.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
xen-unstable changeset: 23335:0957e0c5f0e4
xen-unstable date: Thu May 12 09:15:05 2011 +0100
| -rw-r--r-- | xen/arch/x86/hvm/irq.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/xen/arch/x86/hvm/irq.c b/xen/arch/x86/hvm/irq.c index f1deada076..f560e392e6 100644 --- a/xen/arch/x86/hvm/irq.c +++ b/xen/arch/x86/hvm/irq.c @@ -31,7 +31,7 @@ static void assert_irq(struct domain *d, unsigned ioapic_gsi, unsigned pic_irq) { int pirq = domain_emuirq_to_pirq(d, ioapic_gsi); - if ( pirq != IRQ_UNBOUND ) + if ( hvm_domain_use_pirq(d, pirq) ) { send_guest_pirq(d, pirq); return; @@ -43,7 +43,8 @@ static void assert_irq(struct domain *d, unsigned ioapic_gsi, unsigned pic_irq) /* Must be called with hvm_domain->irq_lock hold */ static void deassert_irq(struct domain *d, unsigned isa_irq) { - if ( domain_emuirq_to_pirq(d, isa_irq) != IRQ_UNBOUND ) + int pirq = domain_emuirq_to_pirq(d, isa_irq); + if ( !hvm_domain_use_pirq(d, pirq) ) vpic_irq_negative_edge(d, isa_irq); } |