diff options
| author | Jan Beulich <jbeulich@suse.com> | 2013-05-15 14:34:05 +0200 |
|---|---|---|
| committer | Jan Beulich <jbeulich@suse.com> | 2013-05-15 14:34:05 +0200 |
| commit | afa65ddfd88184a894d9364bec587554c28c20e0 (patch) | |
| tree | 0248ad009d3cbcc9f75994b5da94584006d11482 | |
| parent | 30256a0ff17f6f3b1278b85103187341d5b0ac42 (diff) | |
| download | xen-afa65ddfd88184a894d9364bec587554c28c20e0.tar.gz xen-afa65ddfd88184a894d9364bec587554c28c20e0.tar.bz2 xen-afa65ddfd88184a894d9364bec587554c28c20e0.zip | |
x86/shadow: fix off-by-one in MMIO permission check
iomem_access_permitted() wants an inclusive range as input.
Also use pfn_to_paddr() in nearby code instead of open coding it.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Tim Deegan <tim@xen.org>
| -rw-r--r-- | xen/arch/x86/mm/shadow/multi.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c index e2160636ba..4c4c2ba97a 100644 --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -604,13 +604,13 @@ _sh_propagate(struct vcpu *v, else if ( d->arch.hvm_domain.is_in_uc_mode ) sflags |= pat_type_2_pte_flags(PAT_TYPE_UNCACHABLE); else - if ( iomem_access_permitted(d, mfn_x(target_mfn), mfn_x(target_mfn) + 1) ) + if ( iomem_access_permitted(d, mfn_x(target_mfn), mfn_x(target_mfn)) ) { if ( p2mt == p2m_mmio_direct ) sflags |= get_pat_flags(v, gflags, gfn_to_paddr(target_gfn), - ((paddr_t)mfn_x(target_mfn)) << PAGE_SHIFT, + pfn_to_paddr(mfn_x(target_mfn)), MTRR_TYPE_UNCACHABLE); else if ( iommu_snoop ) sflags |= pat_type_2_pte_flags(PAT_TYPE_WRBACK); @@ -618,7 +618,7 @@ _sh_propagate(struct vcpu *v, sflags |= get_pat_flags(v, gflags, gfn_to_paddr(target_gfn), - ((paddr_t)mfn_x(target_mfn)) << PAGE_SHIFT, + pfn_to_paddr(mfn_x(target_mfn)), NO_HARDCODE_MEM_TYPE); } } |