diff options
| author | Stefano Stabellini <stefano.stabellini@eu.citrix.com> | 2012-10-26 16:43:12 +0100 |
|---|---|---|
| committer | Stefano Stabellini <stefano.stabellini@eu.citrix.com> | 2012-10-26 16:43:12 +0100 |
| commit | 61bba3307c4cd2b7d6401aad5537a2a7d0f07994 (patch) | |
| tree | cca30711c1e873069fd8f416ad795fe7c1bc2c04 | |
| parent | d43861bd94c71acfb2a81980a840c752cc3feb89 (diff) | |
| download | xen-61bba3307c4cd2b7d6401aad5537a2a7d0f07994.tar.gz xen-61bba3307c4cd2b7d6401aad5537a2a7d0f07994.tar.bz2 xen-61bba3307c4cd2b7d6401aad5537a2a7d0f07994.zip | |
libxl/qemu-xen: use cache=writeback for IDE and SCSI
Change caching mode from writethrough to writeback for upstream QEMU.
After a lengthy discussion, we came up with the conclusion that
WRITEBACK is OK for IDE.
See: http://marc.info/?l=xen-devel&m=133311527009773
Given that the same reasons apply to SCSI as well, change to writeback
for SCSI too.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Committed-by: Ian Campbell <ian.campbell@citrix.com>
xen-unstable changeset: 25989:0807d1f7773d
Backport-requested-by: Ian Campbell <Ian.Campbell@citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
| -rw-r--r-- | tools/libxl/libxl_dm.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index 0c0084f5bb..7662b3d13b 100644 --- a/tools/libxl/libxl_dm.c +++ b/tools/libxl/libxl_dm.c @@ -549,10 +549,10 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc, if (disks[i].is_cdrom) { if (disks[i].format == LIBXL_DISK_FORMAT_EMPTY) drive = libxl__sprintf - (gc, "if=ide,index=%d,media=cdrom", disk); + (gc, "if=ide,index=%d,media=cdrom,cache=writeback", disk); else drive = libxl__sprintf - (gc, "file=%s,if=ide,index=%d,media=cdrom,format=%s", + (gc, "file=%s,if=ide,index=%d,media=cdrom,format=%s,cache=writeback", disks[i].pdev_path, disk, format); } else { if (disks[i].format == LIBXL_DISK_FORMAT_EMPTY) { @@ -575,11 +575,11 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc, */ if (strncmp(disks[i].vdev, "sd", 2) == 0) drive = libxl__sprintf - (gc, "file=%s,if=scsi,bus=0,unit=%d,format=%s", + (gc, "file=%s,if=scsi,bus=0,unit=%d,format=%s,cache=writeback", disks[i].pdev_path, disk, format); else if (disk < 4) drive = libxl__sprintf - (gc, "file=%s,if=ide,index=%d,media=disk,format=%s", + (gc, "file=%s,if=ide,index=%d,media=disk,format=%s,cache=writeback", disks[i].pdev_path, disk, format); else continue; /* Do not emulate this disk */ |