aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJan Beulich <jbeulich@suse.com>2013-01-09 17:19:01 +0100
committerJan Beulich <jbeulich@suse.com>2013-01-09 17:19:01 +0100
commit739174dfee2bd5d0f6c30595cba0fd3c7b6103d5 (patch)
treeaa757f816a76c3842e510a6e2b525bca70188d1c
parent6bb00d9e66c191b86a29e1e3aee253529c16a00e (diff)
downloadxen-739174dfee2bd5d0f6c30595cba0fd3c7b6103d5.tar.gz
xen-739174dfee2bd5d0f6c30595cba0fd3c7b6103d5.tar.bz2
xen-739174dfee2bd5d0f6c30595cba0fd3c7b6103d5.zip
VT-d: fix interrupt remapping source validation for devices behind legacy bridges
Using SVT_VERIFY_BUS here doesn't make sense; native Linux also uses SVT_VERIFY_SID_SQ here instead. This is XSA-33 / CVE-2012-5634. Signed-off-by: Jan Beulich <jbeulich@suse.com> xen-unstable changeset: 26340:19fd1237ff0d xen-unstable date: Wed Jan 9 16:13:26 UTC 2013
-rw-r--r--xen/drivers/passthrough/vtd/intremap.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/xen/drivers/passthrough/vtd/intremap.c b/xen/drivers/passthrough/vtd/intremap.c
index 9c17aaa2d3..7fc58fed12 100644
--- a/xen/drivers/passthrough/vtd/intremap.c
+++ b/xen/drivers/passthrough/vtd/intremap.c
@@ -499,7 +499,7 @@ static void set_msi_source_id(struct pci_dev *pdev, struct iremap_entry *ire)
set_ire_sid(ire, SVT_VERIFY_BUS, SQ_ALL_16,
(bus << 8) | pdev->bus);
else if ( pdev_type(bus, devfn) == DEV_TYPE_LEGACY_PCI_BRIDGE )
- set_ire_sid(ire, SVT_VERIFY_BUS, SQ_ALL_16,
+ set_ire_sid(ire, SVT_VERIFY_SID_SQ, SQ_ALL_16,
PCI_BDF2(bus, devfn));
}
break;