aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefano Stabellini <stefano.stabellini@eu.citrix.com>2011-02-11 17:53:08 +0000
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>2011-02-11 17:53:08 +0000
commit33c82cfa4845bc10f9d7a78d7f282a775ad0d76b (patch)
tree78f828b8b311e3db3e842f6a6dda865d9ada8295
parenta14b0eb5844cda6752aa98ab5509e565b92b17d4 (diff)
downloadxen-33c82cfa4845bc10f9d7a78d7f282a775ad0d76b.tar.gz
xen-33c82cfa4845bc10f9d7a78d7f282a775ad0d76b.tar.bz2
xen-33c82cfa4845bc10f9d7a78d7f282a775ad0d76b.zip
libxl: do not call libxl__file_reference_unmap twice
Fix double free due to libxl__file_reference_unmap(&info->kernel) called multiple times: first at the end of libxl__domain_build and then in libxl_domain_build_info_destroy. Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
-rw-r--r--tools/libxl/libxl_create.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
index 3ee6672820..260d3c0a91 100644
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -196,9 +196,6 @@ int libxl__domain_build(libxl_ctx *ctx, libxl_domain_build_info *info, uint32_t
}
ret = libxl__build_post(ctx, domid, info, state, vments, localents);
out:
- libxl__file_reference_unmap(&info->kernel);
- if (!info->hvm)
- libxl__file_reference_unmap(&info->u.pv.ramdisk);
libxl__free_all(&gc);
return ret;