aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIan Jackson <Ian.Jackson@eu.citrix.com>2011-02-04 18:46:22 +0000
committerIan Jackson <Ian.Jackson@eu.citrix.com>2011-02-04 18:46:22 +0000
commite887904db62c8d085cf6a1c829c9f615d049eb9c (patch)
treeaaa312ff494ee511eac57d2063058746c2c1eb10
parenta7dce8960cae2f8bca0cafe52adb039f0df4d8b6 (diff)
downloadxen-e887904db62c8d085cf6a1c829c9f615d049eb9c.tar.gz
xen-e887904db62c8d085cf6a1c829c9f615d049eb9c.tar.bz2
xen-e887904db62c8d085cf6a1c829c9f615d049eb9c.zip
libxl: vncviewer: fix use-after-free
This bug can prevent xl vncviewer from working at all. Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
-rw-r--r--tools/libxl/libxl.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index 9359f515be..0ca21e65db 100644
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -848,9 +848,8 @@ int libxl_vncviewer_exec(libxl_ctx *ctx, uint32_t domid, int autopass)
}
skip_autopass:
- libxl__free_all(&gc);
libxl__exec(autopass_fd, -1, -1, args[0], args);
- return 0;
+ abort();
}
/******************************************************************************/