aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKeir Fraser <keir.fraser@citrix.com>2010-03-09 17:53:01 +0000
committerKeir Fraser <keir.fraser@citrix.com>2010-03-09 17:53:01 +0000
commitfcd0e226300c0bb0917fdf7c464157f31ab3b1be (patch)
tree5a16a21fefe008a9f6df8bba71785a5effb4a02a
parenta0c1a380cba507a16ced03f01a3d927fd4ac6229 (diff)
downloadxen-fcd0e226300c0bb0917fdf7c464157f31ab3b1be.tar.gz
xen-fcd0e226300c0bb0917fdf7c464157f31ab3b1be.tar.bz2
xen-fcd0e226300c0bb0917fdf7c464157f31ab3b1be.zip
tmem: typo causes incorrect return on out-of-memory
This classic typo in tmem would result in a false positive report on a tmem "put" operation if a (unfragmented) page of memory is completely unavailable. Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>
-rw-r--r--xen/common/tmem.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/xen/common/tmem.c b/xen/common/tmem.c
index c2f6c74f1f..42f4569dbc 100644
--- a/xen/common/tmem.c
+++ b/xen/common/tmem.c
@@ -1308,7 +1308,7 @@ static NOINLINE int do_tmem_put(pool_t *pool,
copy_uncompressed:
if ( ( pgp->pfp = tmem_page_alloc(pool) ) == NULL )
{
- ret == -ENOMEM;
+ ret = -ENOMEM;
goto delete_and_free;
}
/* tmh_copy_from_client properly handles len==0 (TMEM_NEW_PAGE) */