aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKeir Fraser <keir.fraser@citrix.com>2010-01-21 15:13:00 +0000
committerKeir Fraser <keir.fraser@citrix.com>2010-01-21 15:13:00 +0000
commit379e63ed3da8f6d874d9bc5d6fa05a85afb60238 (patch)
treec2a17018642c7858ddf3b9c62b3f7e7ca96d9a5b
parent231123f7554695471b7c3714ca3a815f1a13e780 (diff)
downloadxen-379e63ed3da8f6d874d9bc5d6fa05a85afb60238.tar.gz
xen-379e63ed3da8f6d874d9bc5d6fa05a85afb60238.tar.bz2
xen-379e63ed3da8f6d874d9bc5d6fa05a85afb60238.zip
x86: kill msix_flush_writes()
The (only) two callers of it don't need it, as the MSI-X case of msi_set_mask_bit() already does the necessary readl(). Signed-off-by: Jan Beulich <jbeulich@novell.com>
-rw-r--r--xen/arch/x86/msi.c23
1 files changed, 0 insertions, 23 deletions
diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c
index 67f48a3555..06b53a202f 100644
--- a/xen/arch/x86/msi.c
+++ b/xen/arch/x86/msi.c
@@ -327,27 +327,6 @@ static void msix_set_enable(struct pci_dev *dev, int enable)
}
}
-static void msix_flush_writes(unsigned int irq)
-{
- struct msi_desc *entry = irq_desc[irq].msi_desc;
-
- BUG_ON(!entry || !entry->dev);
- switch (entry->msi_attrib.type) {
- case PCI_CAP_ID_MSI:
- /* nothing to do */
- break;
- case PCI_CAP_ID_MSIX:
- {
- int offset = PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET;
- readl(entry->mask_base + offset);
- break;
- }
- default:
- BUG();
- break;
- }
-}
-
int msi_maskable_irq(const struct msi_desc *entry)
{
BUG_ON(!entry);
@@ -409,13 +388,11 @@ static int msi_get_mask_bit(const struct msi_desc *entry)
void mask_msi_irq(unsigned int irq)
{
msi_set_mask_bit(irq, 1);
- msix_flush_writes(irq);
}
void unmask_msi_irq(unsigned int irq)
{
msi_set_mask_bit(irq, 0);
- msix_flush_writes(irq);
}
static struct msi_desc* alloc_msi_entry(void)